Repository navigation
DeltaSignal on beta, from #757's review: docs and the toggle test - #758
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
…gle test checks it The nginx README and the e2e toggle test's header no longer say DeltaSignal cannot work on beta; the README says where its service runs and that beta's checks cover it. The toggle test now checks the button on beta as well as under the dev server. The search-answer flag's comment, also stale, names beta too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the next PR, which keeps the toggle test's recorded name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up #757 (DeltaSignal's Perturb button on beta) with the low findings from its review.
Changes
deploy/nginx/README.mdno longer says DeltaSignal cannot work on beta. It says:/api/is DeltaSignal's route;/api/pathwaysis checked with the rest of beta.e2e/deltasignal-toggle.spec.ts: its header no longer says/apiis only the dev server's. The "offers it" case now runs for bothdevelopmentandbeta.environments.ts: the search-answer flag's comment said onlydevelopmenthad it. Beta has had it for a while, and the comment now says so.Noted from the review, not changed here:
/api/solvehas no rate limit of its own beyond beta's site-wide one. The route was already reachable before Offer DeltaSignal's Perturb button on beta #757.Spec: none.
🤖 Generated with Claude Code