Skip to content

Migrate DeviceInfoModuleTest off JUnit3 TestCase base #59431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hick209 wants to merge 1 commit into from
Closed

Migrate DeviceInfoModuleTest off JUnit3 TestCase base #59431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .../ReactAndroid/src/test/java/com/facebook/react/modules/deviceinfo/DeviceInfoModuleTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import com.facebook.testutils.shadows.ShadowNativeMap
import com.facebook.testutils.shadows.ShadowReadableNativeMap
import com.facebook.testutils.shadows.ShadowSoLoader
import com.facebook.testutils.shadows.ShadowWritableNativeMap
import junit.framework.TestCase
import org.assertj.core.api.Assertions.assertThat
import org.junit.After
import org.junit.Before
Expand Down Expand Up @@ -64,7 +63,7 @@ import org.robolectric.annotation.Config
ShadowReadableNativeMap::class,
],
)
class DeviceInfoModuleTest : TestCase() {
class DeviceInfoModuleTest {

private lateinit var deviceInfoModule: DeviceInfoModule
private lateinit var fakePortraitDisplayMetrics: WritableMap
Expand All @@ -73,7 +72,7 @@ class DeviceInfoModuleTest : TestCase() {
private lateinit var displayMetricsHolder: MockedStatic<DisplayMetricsHolder>

@Before
public override fun setUp() {
fun setUp() {
ReactNativeFeatureFlagsForTests.setUp()
fakePortraitDisplayMetrics = JavaOnlyMap()
fakePortraitDisplayMetrics.putInt("width", 100)
Expand Down
Loading