Remove disabled accessibility manager integration test (#58612) - #58612
Closed
rubennorte wants to merge 6 commits into
Closed
rubennorte wants to merge 6 commits into
rubennorte wants to merge 6 commits into
Conversation
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120923184. |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 11:27
90b9cae to
8d699b4
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 12:02
8d699b4 to
99bb77d
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 12:31
99bb77d to
aea7e5b
Compare
Summary: Expose the renderer proxy as `Renderer` from `react-native/unstable-internals-do-not-use`. Generated Codegen modules can be emitted into consumer packages and need a package entry point for dispatching renderer commands without deep imports. Changelog: [Internal] Differential Revision: D120991150
Summary: Use the React Native root and supported secondary entry points for public APIs used by the Jest preset. Resolve implementation modules through package-relative paths so the preset does not depend on unsupported package subpaths. Changelog: [Internal] Differential Revision: D120717568
Summary: Generate view configs and Codegen fixtures using supported React Native entry points or values derived from their exports. Generated view config modules can be emitted into arbitrary consumer package locations, so they cannot use a package-relative path back into React Native. Keep `ConditionallyIgnoredEventHandlers` centralized and expose it from the explicitly unstable compatibility entry point instead of duplicating its platform-specific semantics in generated output. Changelog: [Internal] Differential Revision: D120717571
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 13:03
aea7e5b to
70c8d77
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
2 times, most recently
from
September 21, 2026 13:50
70c8d77 to
c72a913
Compare
Summary: Use global DOM APIs, supported React Native entry points, and package-relative implementation imports throughout Fantom. Use the renderer-only private interface for the existing public-instance conversion helpers instead of importing Node internals. Changelog: [Internal] Differential Revision: D120717572
Summary: Migrate the remaining package consumers to React Native root exports, documented secondary entry points, global web APIs, or package-relative implementation paths. Use feature flags instead of directly invoking web API setup helpers. Changelog: [Internal] Differential Revision: D120717573
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 14:04
c72a913 to
3746193
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Sep 21, 2026
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 14:09
3746193 to
2ab78ce
Compare
Summary: Pull Request resolved: react#58612 Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D120923184
rubennorte
force-pushed
the
export-D120923184
branch
from
September 21, 2026 15:34
2ab78ce to
9f4f975
Compare
|
This pull request has been merged in 3d93b5a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Remove the RNTester accessibility manager integration test. The native harness has kept it disabled because the underlying native module is unavailable, and its setup depends on a private native-module API.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D120923184