Skip to content

Scope INTERNAL_CALLSITES_REGEX to the react-native package (#58577) - #58577

Open
vzaidman wants to merge 1 commit into
mainfrom
export-D120179017
Open

vzaidman wants to merge 1 commit into
mainfrom
export-D120179017

Conversation

@vzaidman

@vzaidman vzaidman commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Summary:

The INTERNAL_CALLSITES_REGEX entries like /Libraries/Core/.+\.js$ match any path containing that substring, including unrelated packages that happen to have a Libraries/ directory.

Prefixing them with /react-native/ is always correct: these files ship inside the react-native package, so they appear either as .../packages/react-native/Libraries/... in the monorepo or as .../node_modules/react-native/Libraries/... in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro INTERNAL_CALLSITES_REGEX to the react-native package to avoid collapsing unrelated frames

Differential Revision: D120179017

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2026
@meta-codesync

meta-codesync Bot commented Sep 17, 2026

Copy link
Copy Markdown

@vzaidman has exported this pull request. If you are a Meta employee, you can view the originating Diff in D120179017.

@meta-codesync meta-codesync Bot changed the title Scope INTERNAL_CALLSITES_REGEX to the react-native package Scope INTERNAL_CALLSITES_REGEX to the react-native package (#58577) Sep 21, 2026
meta-codesync Bot pushed a commit that referenced this pull request Sep 21, 2026
Summary:

The `INTERNAL_CALLSITES_REGEX` entries like `/Libraries/Core/.+\.js$` match any path containing that substring, including unrelated packages that happen to have a `Libraries/` directory.

Prefixing them with `/react-native/` is always correct: these files ship inside the `react-native` package, so they appear either as `.../packages/react-native/Libraries/...` in the monorepo or as `.../node_modules/react-native/Libraries/...` in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro `INTERNAL_CALLSITES_REGEX` to the `react-native` package to avoid collapsing unrelated frames

Differential Revision: D120179017
meta-codesync Bot pushed a commit that referenced this pull request Sep 21, 2026
Summary:
Pull Request resolved: #58577

The `INTERNAL_CALLSITES_REGEX` entries like `/Libraries/Core/.+\.js$` match any path containing that substring, including unrelated packages that happen to have a `Libraries/` directory.

Prefixing them with `/react-native/` is always correct: these files ship inside the `react-native` package, so they appear either as `.../packages/react-native/Libraries/...` in the monorepo or as `.../node_modules/react-native/Libraries/...` in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro `INTERNAL_CALLSITES_REGEX` to the `react-native` package to avoid collapsing unrelated frames

Differential Revision: D120179017
meta-codesync Bot pushed a commit that referenced this pull request Sep 22, 2026
Summary:

The `INTERNAL_CALLSITES_REGEX` entries like `/Libraries/Core/.+\.js$` match any path containing that substring, including unrelated packages that happen to have a `Libraries/` directory.

Prefixing them with `/react-native/` is always correct: these files ship inside the `react-native` package, so they appear either as `.../packages/react-native/Libraries/...` in the monorepo or as `.../node_modules/react-native/Libraries/...` in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro `INTERNAL_CALLSITES_REGEX` to the `react-native` package to avoid collapsing unrelated frames

Differential Revision: D120179017
meta-codesync Bot pushed a commit that referenced this pull request Sep 22, 2026
Summary:
Pull Request resolved: #58577

The `INTERNAL_CALLSITES_REGEX` entries like `/Libraries/Core/.+\.js$` match any path containing that substring, including unrelated packages that happen to have a `Libraries/` directory.

Prefixing them with `/react-native/` is always correct: these files ship inside the `react-native` package, so they appear either as `.../packages/react-native/Libraries/...` in the monorepo or as `.../node_modules/react-native/Libraries/...` in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro `INTERNAL_CALLSITES_REGEX` to the `react-native` package to avoid collapsing unrelated frames

Differential Revision: D120179017
meta-codesync Bot pushed a commit that referenced this pull request Sep 22, 2026
Summary:

The `INTERNAL_CALLSITES_REGEX` entries like `/Libraries/Core/.+\.js$` match any path containing that substring, including unrelated packages that happen to have a `Libraries/` directory.

Prefixing them with `/react-native/` is always correct: these files ship inside the `react-native` package, so they appear either as `.../packages/react-native/Libraries/...` in the monorepo or as `.../node_modules/react-native/Libraries/...` in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro `INTERNAL_CALLSITES_REGEX` to the `react-native` package to avoid collapsing unrelated frames

Differential Revision: D120179017
Summary:
Pull Request resolved: #58577

The `INTERNAL_CALLSITES_REGEX` entries like `/Libraries/Core/.+\.js$` match any path containing that substring, including unrelated packages that happen to have a `Libraries/` directory.

Prefixing them with `/react-native/` is always correct: these files ship inside the `react-native` package, so they appear either as `.../packages/react-native/Libraries/...` in the monorepo or as `.../node_modules/react-native/Libraries/...` in installs. Unrelated third-party frames are no longer collapsed as internal.

Changelog:
[General][Fixed] - Scope Metro `INTERNAL_CALLSITES_REGEX` to the `react-native` package to avoid collapsing unrelated frames

Differential Revision: D120179017

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant