Repository navigation
fix: reset child column scroll position when switching parent option #667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
HHHSL
wants to merge
1
commit into
react-component:master
Choose a base branch
from
HHHSL:fix/reset-child-column-scroll
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import React from 'react'; | ||
| import { render } from '@testing-library/react'; | ||
| import Cascader from '../src'; | ||
| import { clickOption, expectOpen } from './util'; | ||
|
|
||
| describe('Cascader.Scroll', () => { | ||
| const options = ['aa', 'bb'].map(prefix => ({ | ||
| value: prefix, | ||
| label: prefix, | ||
| children: Array.from({ length: 30 }, (_, i) => ({ | ||
| value: `${prefix}-${i}`, | ||
| label: `${prefix}-${i}`, | ||
| })), | ||
| })); | ||
|
|
||
| const renderCascader = () => | ||
| render( | ||
| <Cascader options={options} open> | ||
| <input readOnly /> | ||
| </Cascader>, | ||
| ); | ||
|
|
||
| const mockScrollTo = (menu: HTMLElement) => { | ||
| const calls: Array<[number, number]> = []; | ||
| menu.scrollTo = ((left: number, top: number) => { | ||
| calls.push([left, top]); | ||
| }) as HTMLElement['scrollTo']; | ||
| return calls; | ||
| }; | ||
|
|
||
| beforeEach(() => { | ||
| jest.useFakeTimers(); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jest.useRealTimers(); | ||
| }); | ||
|
|
||
| it('reset child column scroll when switching parent', () => { | ||
| const { container } = renderCascader(); | ||
|
|
||
| expectOpen(container); | ||
|
|
||
| // Expand the first parent to show the child column | ||
| clickOption(container, 0, 0); | ||
| let menus = container.querySelectorAll('.rc-cascader-menu'); | ||
| expect(menus).toHaveLength(2); | ||
|
|
||
| const calls = mockScrollTo(menus[1] as HTMLElement); | ||
|
|
||
| // Switch to the second parent: the child column shows a fresh list | ||
| clickOption(container, 0, 1); | ||
|
|
||
| menus = container.querySelectorAll('.rc-cascader-menu'); | ||
| expect(menus).toHaveLength(2); | ||
| expect(calls).toContainEqual([0, 0]); | ||
| }); | ||
|
|
||
| it('keep child column scroll when options are unchanged', () => { | ||
| const { container, rerender } = renderCascader(); | ||
|
|
||
| expectOpen(container); | ||
|
|
||
| clickOption(container, 0, 0); | ||
| const menus = container.querySelectorAll('.rc-cascader-menu'); | ||
| expect(menus).toHaveLength(2); | ||
|
|
||
| const calls = mockScrollTo(menus[1] as HTMLElement); | ||
|
|
||
| // Re-render with the same parent column content: scroll must not be touched | ||
| rerender( | ||
| <Cascader options={options} open> | ||
| <input readOnly /> | ||
| </Cascader>, | ||
| ); | ||
|
|
||
| expect(calls).toHaveLength(0); | ||
| }); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
在绘制前重置滚动位置。
切换父选项时,复用的
<ul>可能先以旧滚动位置绘制。useEffect随后才调用scrollTo(0, 0),用户会看到短暂跳动。请使用兼容 SSR 的布局效果,在浏览器绘制前执行这次重置。根据检索到的 React 学习记录,客户端布局效果可避免这类绘制后跳动。🤖 Prompt for AI Agents
Source: Learnings