Repository navigation
Backport: Fix table name parsing for INSERT INTO <table> WITH (<hints>) - #1425
Merged
aidanharan merged 1 commit intoOct 27, 2026
Merged
aidanharan merged 1 commit into
aidanharan merged 1 commit into
Conversation
…s-sqlserver#1424) (cherry picked from commit 1c44234)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1424 to
8-1-stable, as requested.INSERT INTO books WITH (TABLOCK) (title) ...fails withTable 'books WITH' doesn't existbecause the table hint ends up in the parsed table name. This strips the hint when parsing the name and when looking for the identity column.Cherry-picked cleanly. The CHANGELOG entry sits above
v8.1.4for the next release. Tests pass against Rails 8.1, and the new test fails on8-1-stablewithout the fix.