Repository navigation
Publish ShardThroughputReadings for all shards; shared rate meter - #6887
Open
nadav-govari wants to merge 1 commit into
Open
nadav-govari wants to merge 1 commit into
nadav-govari wants to merge 1 commit into
Conversation
nadav-govari
added this pull request to stack #6888
October 8, 2026 15:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nadav-govari
force-pushed
the
nadav/pr2
branch
from
October 8, 2026 15:10
03c3482 to
45efeb2
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03c3482618
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In preparation for the gRPC shard throughput readings, this creates a shared rate meter that tracks all readings on the ingester. It sits at the top level of the ingester state so that it doesn't require locking the state or WAL to update, meaning it won't contend with other operations for those locks and can function independently.
The shard throughput readings task will eventually feed these readings to the RPC. It harvests the last second of readings from the shared rate meter, and writes them to a watch channel, which will eventually be used by the IndexerStateReporter. For now, the receiver side of the channel is unused.
How was this PR tested?
Unit tests.