Repository navigation
Use detailed mrecordlog responses; Add queue size tracking to ingester shard - #6884
Open
nadav-govari wants to merge 1 commit into
Open
nadav-govari wants to merge 1 commit into
nadav-govari wants to merge 1 commit into
Conversation
nadav-govari
marked this pull request as ready for review
October 8, 2026 15:03
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
nadav-govari
added this pull request to stack #6888
October 8, 2026 15:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 1 of a stack moving ingester shard readings and indexing plans to gRPC, and reworking ingest scaling.
This PR introduces queue size tracking for ingester shards. The readings come from directly from mrecordlog, which returns the size of the memory queue after every append/truncate operation.
Doc batch sizing is now more accurate as well. Rather than estimating values, which was off by 4 bytes per doc, we now compute it directly.
Various helpers were updated/removed as needed, and tests were updated.