Repository navigation
fix(otlp): return application/x-protobuf response format on otlp endpoints - #6801
Tyagiquamar wants to merge 2 commits into
Conversation
…oints Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 284e6554b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hi, just following up on this when you get a chance. The branch is up to date and checks are green. If it looks good from your side, it should be ready to merge. Happy to make any changes if needed. Thanks! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
1 participant
Fixes #6786.
Successful OTLP HTTP ingest responses now encode the exported response as binary protobuf and send
Content-Type: application/x-protobuf. Ingest errors retain the existing JSON error format.All four default/indexed logs and traces response annotations declare the protobuf media type in OpenAPI. The error-only result has an explicit unit success type, and response-decoding tests pass byte slices to Prost. Regressions check both the JSON error response and generated OpenAPI media types, alongside the existing compressed/uncompressed ingest cases.
Docker validation with Rust 1.96.1, Protobuf compiler and the repository's nightly formatter passed:
cargo test --locked -p quickwit-serve otlp_api::rest_handler::tests --lib -j 2: four focused test functions passed.cargo build --locked -p quickwit-serve --lib -j 2: passed.cargo fmt --all -- --check: passed.make fmt: formatting, license-header and log-format checks passed during preparation; the final source also passed the formatting check above.git diff --check: passed.The full test suite and live ingest service integration tests were not run locally.