Repository navigation
Show Positron's Viewer stop button for Quarto previews - #1193
Open
juliasilge wants to merge 2 commits into
Open
juliasilge wants to merge 2 commits into
juliasilge wants to merge 2 commits into
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PreviewPanel.stoppable) posit-dev/positron#16602In Positron, the Viewer now shows a stop button for Quarto previews. Before this PR, the only way to stop
quarto previewwas to find the Quarto Preview terminal and press Ctrl+C or close the terminal.The Positron PR adds
PreviewPanel.stoppableandonDidRequestStopto the Positron API. The extension setsstoppablewhile the preview server runs, and Positron shows the button and reports clicks. Quarto starts and stops the server, so Quarto decides when the button shows.The extension uses feature detection (
"onDidRequestStop" in panel), not a version check. On older Positron versions and in VS Code, nothing changes. A local type covers the new members until@posit-dev/positronships them, soengines.positrondoes not change.Some known limitations:
cmdpath), Ctrl+C in the terminal leaves the button visible until the terminal closes. A click on this button does no harm, and it closes the preview.Verification
yarn build-test: passes, includingtsc --noEmit.yarn test(labelmain): the 6 new tests pass. 178 passing, 3 pending, 1 failing. The failure is the notebook renderer build test, which fails on stale chunks in my localout/markdownit. This PR does not change that code.