Repository navigation
Conversation
The light and dark themes now share one announcement banner rule, and the prerelease banner only overrides its colour. The navbar drops a selector for an icon the site no longer uses. The page tweaks script detects macOS from the user agent instead of the deprecated navigator.platform, and marks pymd comments with a class instead of setting the font weight inline.
Two are backups of older renders that nothing ever referenced, and two are home page drafts from March 2023 that newer images replaced.
The old gallery page was the only user of these rules, and the new gallery doesn't use them.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: #2140 first, then #2298, then the restyle with design tokens, which isn't open yet.
This tidies leftovers from the move of the site theme into the
quartoorgextension in #2222.The rendered site doesn't change.
#quarto-announcementrule in_announcement.scss, and the prerelease banner only overrides its background colour..bi-twitterselector.page-tweaks.htmldetects macOS fromnavigator.userAgentinstead of the deprecatednavigator.platform. Macs and iPads in desktop mode still get ⌘, and other devices ⌃..pymdcomments with a class, and thefont-weightlives in the stylesheet instead of an inline style._cards.scssdrops the.carousel*and.gallery-categoryrules, which only the old gallery page uses.Four files in
images/go. Nothing references them, and git history shows why:hello-jupyter.bak.pngandhello-julia.bak2.pngare backups of older renders, saved in d1c85bf and 74b66ba.demo-jupyter.png(0596468) andhello-jupyter-notebook.png(404c16d) were home page drafts from March 2023, replaced within two days bydemo-jupyter-plain.png(47b63d7), which is still in use.Screenshots of 15 pages and the prerelease banner, in light and dark at three widths, match
main.Two of them, pixel-identical:
The compiled CSS differs only by the removed selector, the new class rule, the dropped duplicate declarations and the removed card rules.
It merges after #2140, because #2140 replaces the old gallery page that used the removed card rules.
Both add an import to
_site.scss, so the rebase onto #2140 needs a one-line conflict fix.The restyle builds on this one.