Repository navigation
[Sync to prerelease] Reserve the red announcement banner for prerelease and fix its contrast - #2277
Merged
Merged
Conversation
Member
|
/deploy-preview |
Contributor
Author
📝 Preview Deployment🔍 Full site preview: https://deploy-preview-2277.quarto.org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sync of #2276 to
prerelease.Original PR
Reserve the red announcement banner for prerelease and fix its contrast
The announcement banner colours were mixed up:
main(before)#447099#ff0039prerelease(before)#ff0039(Cosmo$danger)#ff0039White on
#ff0039gives 3.95:1. WCAG 1.4.3 needs 4.5:1. The prerelease axe scan flags it on all 334 light/dark pages (run 37517108158).mainshows no finding only because it has no announcement now.This PR reserves red for
prerelease, in both modes:theme-dark.scss: themaindark banner is#447099, the same as light mode (5.22:1).theme-prerelease-docs.scss→theme-prerelease-banner.scss. The new name tells you that the file only styles the banner. The colour is#e60033(4.76:1)._quarto-prerelease-docs.yml: adds the banner file to the dark theme too.These files are identical on
mainandprerelease, so the automatic backport should apply cleanly.Verification:
404.qmdwith each profile and checked the compiled CSS.mainhas#447099in light and dark.prereleasehas#e60033in light and dark, and it overrides the#447099rule.color-contrast :: #ffffff on #ff0039cleared (1002 instances), with no regressions.Conflicts with #2222, which moves these rules into
_extensions/quartoorg/scss/.