Repository navigation
Backport five accessibility fixes to prerelease - #2271
Merged
Merged
Conversation
* Heading order fixes * Remove extra h1 and reflow * Fix headings that should have been "captions" * Update freeze (cherry picked from commit c56f6cb)
…2235) * Use the theme link color for the extensions category chooser The chooser tiles hard-coded #5092dd, which is 3.23:1 on white (WCAG 1.4.3 needs 4.5:1). var(--bs-link-color) gives 5.15:1 in light mode and 7.27:1 in dark mode. Clears axe color-contrast-0f9515 (20 instances on 5 pages). * Underline links in listing-table descriptions Quarto's listing-table styles remove link underlines, so description links rely on color alone: 2.23:1 against body text, short of the 3:1 WCAG 1.4.1 needs. Clears axe link-in-text-block-82c7eb and the extensions-page instances of link-in-text-block-7b0c90. (cherry picked from commit e26940f)
* Make the tool choosers consistent with a shared page-chooser shortcode * Use --bs-border-color for chooser tiles in light mode (cherry picked from commit dab304a)
…again (#2257) #2235 left out the closing brace of the listing-description link rule. Browsers then read the #2234 rule for screen-reader-only code blocks as a nested rule that never matches, and the blocks became scrollable regions again (axe scrollable-region-focusable). (cherry picked from commit 6f27b3f)
Contributor
Screen readers announce an iframe by its title. The video shortcode
emits title="" when the author omits the title argument, so these two
embeds failed axe's frame-title check (serious, WCAG 2.0 A, SC 4.1.2).
Add title="CERN: The Journey of Discovery" to the two live {{< video >}}
calls, and to the escaped copies the same pages display as source, so
the shown example matches the rendered output. In tables.qmd the call
sits inside a data-qmd="..." attribute, so the title uses single quotes.
(cherry picked from commit ccf7a9e)
cwickham
changed the title
Contributor
3 of 5 tasks
Merged
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automatic backport failed for these five PRs because of cherry-pick conflicts. This PR applies them to
prereleaseby hand, in the order that they merged:I checked all PRs merged to
mainsince 2026-07-01. These five are the only ones that are not onprerelease.#2227 and #2141 had a conflict in
_freeze/docs/authoring/tables/execute-results/html.json. After both PRs, the source oftables.qmdonprereleaseis the same as onmain. Thus this file is now the same as onmain. The other freeze files from #2227 come frommainwithout change, because their sources are the same on both branches.Axe scan
I rendered the site with
QUARTO_PROFILE=prerelease-docsand scanned all 373 pages withquarto call axe. Then I compared the result with the prerelease scan of 2026-10-02 (run 37054502660).heading-order,color-contrast :: #5092dd on #ffffff, andlink-in-text-block :: tr > td > .listing-description > a.frame-title :: iframedecreased from 3 to 1 instance. The one that remains is oncode-annotation.html, which Add iframe titles to embedded videos #2141 does not change.image-altandlink-namefindings onmarkdown-basics.htmlmoved from.oddrows to.evenrows. The prerelease baseline already has the.evensignatures, so they are baselined.These PRs do not fix the 4 findings that remain. The banner contrast (
#ffffff on #ff0039, 334 pages) is separate work. The others are threescrollable-region-focusablesignatures.