Repository navigation
Skip the Shift+Tab panel click test in macOS WebKit - #15232
Merged
Merged
Conversation
The test holds Shift+Tab, plus Option in WebKit so that Tab reaches links, then clicks a textarea in a tabset panel. On macOS, WebKit does not focus a control clicked while Option is held: a probe run showed pointerdown, mousedown and click reaching the textarea, none of them cancelled, with no focus change and the panel left selected. With Option released, the same click focuses the textarea. The tabset code does not take part, so the nightly macOS failure is a WebKit platform behavior, not a regression. Releasing Option before the click would make the test pass but empty it: the tabset script ends its Shift+Tab state on any keyup, so the click would no longer check that pointerdown ends it. The test is skipped for WebKit on macOS only; Linux WebKit, Chromium and Firefox keep the check.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly macOS Playwright job fails in WebKit on
clicking a panel control while Shift+Tab is held keeps that panel, added in #15155. It fails on every macOS run since then, and passes on Linux.Root cause
The test holds Shift+Tab, plus Option in WebKit because WebKit needs Option to Tab to links, then clicks a textarea in a tabset panel. On macOS, WebKit does not focus a control clicked while Option is held. A probe run on
macos-latesttraced the click: pointerdown, mousedown and click reach the textarea and none is cancelled, but focus stays on the previous link and the panel stays selected. The same click with Option released focuses the textarea, and Chromium focuses it with any key held. The tabset script does not take part.Fix
The test is skipped for WebKit on macOS. Releasing Option before the click would make it pass but no longer test anything: the tabset script ends its Shift+Tab state on any keyup, so the click would not check that pointerdown ends it. WebKit on Linux, Chromium and Firefox keep the check.
Checklist
I have (if applicable):
AI-assisted PR
Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.