Skip to content

Fix dracula revealjs theme coloring <b> in callout titles - #15037

Merged
cderv merged 2 commits into
mainfrom
fix/dracula-callout-tile-typo
Oct 13, 2026
Merged

cderv merged 2 commits into
mainfrom
fix/dracula-callout-tile-typo

Conversation

@cderv

@cderv cderv commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

In the dracula revealjs theme, a raw HTML <b> inside a callout title gets the theme's bold color (orange), while <strong> in the same title keeps the body color.

Callout titles are wrapped in <strong>, so the theme excludes bold elements inside .callout-title from --r-bold-color (added in 3a9a494). The <b> part of that selector was written .callout-tile b, which matches nothing.

The selector is fixed in dracula.scss and also in revealjs-theme-0001-dracula.patch, which regenerates the theme from upstream reveal.js. Otherwise the next theme update would bring the typo back. The Playwright test for the dracula callout title now also checks <b> and nested <strong> in a title.

Checklist

I have (if applicable):

  • referenced the GitHub issue this PR closes
  • updated the appropriate changelog in the PR
  • ensured the present test suite passes
  • added new tests
  • created a separate documentation PR in Quarto's website repo and linked it to this PR
AI-assisted PR
  • AI tool used: Claude Code
  • Codebase grounding: local clone
  • Human review: I have reviewed, tested, and verified the AI-generated content before submitting.

Note: autonomous AI agents submitting PRs without human oversight are not permitted — see the Code of Conduct.

@posit-snyk-bot

posit-snyk-bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

cderv added 2 commits October 13, 2026 17:53
The dracula theme colors bold text with --r-bold-color but excludes
callout titles, which Quarto wraps in <strong>. The exclusion for <b>
targeted `.callout-tile b`, a class no element has, so a raw HTML <b>
in a callout title still turned orange while <strong> did not.

The theme file is regenerated from the reveal.js upstream theme through
revealjs-theme-0001-dracula.patch, so the patch gets the same fix;
otherwise the next theme update would bring the typo back.
@cderv
cderv force-pushed the fix/dracula-callout-tile-typo branch from dc58f8b to e97d4aa Compare October 13, 2026 15:57
@cderv
cderv merged commit fa5267f into main Oct 13, 2026
51 checks passed
@cderv
cderv deleted the fix/dracula-callout-tile-typo branch October 13, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants