Skip to content

Fix nightly smoke dispatch picking a stale create-release run #14949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cderv merged 2 commits into from
Sep 25, 2026
Merged

Fix nightly smoke dispatch picking a stale create-release run #14949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45bae20
Resolve latest nightly without filtered runs listing
cderv Sep 24, 2026
1806408
Compare nightly run age in seconds for the staleness check
cderv Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions .github/workflows/test-smokes-built.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,21 @@ jobs:
run: |
run_id="$RUN_ID_INPUT"
if [ -z "$run_id" ]; then
run_id="$(gh run list --repo "$GITHUB_REPOSITORY" --workflow create-release.yml \
--branch main --status success --limit 1 --json databaseId --jq '.[0].databaseId // empty')"
fi
if [ -z "$run_id" ]; then
echo "::error::No successful create-release run was found. Provide a run ID or complete a create-release run first."
exit 1
# The runs listing intermittently returns an outdated result set when
# filtered by branch or status, so filter and sort client-side.
latest="$(gh run list --repo "$GITHUB_REPOSITORY" --workflow create-release.yml \
--limit 30 --json databaseId,createdAt,headBranch,conclusion \
--jq '[.[] | select(.headBranch == "main" and .conclusion == "success")] | sort_by(.createdAt) | last // empty | "\(.databaseId) \(.createdAt)"')"
read -r run_id created_at <<<"$latest"
if [ -z "$run_id" ]; then
echo "::error::No successful create-release run was found. Provide a run ID or complete a create-release run first."
exit 1
fi
age_seconds=$(( $(date +%s) - $(date -d "$created_at" +%s) ))
if [ "$age_seconds" -gt $(( 3 * 86400 )) ]; then
echo "::error::Latest successful create-release run ${run_id} is $(( age_seconds / 86400 )) days old (${created_at}); the runs listing may be outdated. Provide a run ID explicitly."
exit 1
fi
fi
sha="$(gh run view "$run_id" --repo "$GITHUB_REPOSITORY" --json headSha --jq '.headSha // empty')"
if [ -z "$sha" ]; then
Expand Down
Loading