Guard vendored CRI message handling against null teardown frames - #14908
Merged
cderv merged 2 commits intoSep 18, 2026
Merged
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Co-authored-by: cderv <6791940+cderv@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix uncaught TypeError in Chrome DevTools Protocol client
Guard vendored CRI message handling against null teardown frames
Sep 18, 2026
cderv
marked this pull request as ready for review
September 18, 2026 11:42
Member
|
I am merging because it fixes what it should (https://github.com/quarto-dev/quarto-cli/actions/runs/35338223335/job/105577961196) and the test above are failing on main - looking at that in another PR. |
cderv
deleted the
copilot/fix-uncaught-typeerror-axe-transport-failclosed
branch
September 18, 2026 11:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Welcome to the quarto GitHub repo!
We are always happy to hear feedback from our users.
To file a pull request, please follow these instructions : https://github.com/quarto-dev/quarto-cli?tab=contributing-ov-file
Also, please complete and keep the checklist below.
Description
The vendored Chrome DevTools Protocol client could throw an uncaught
TypeErrorduring browser/socket teardown when a WebSocket frame parsed tonull. This updates the message handler to ignore null/non-object teardown frames so the axe transport fail-closed path rejects in-flight commands without crashing the test module.Problem
_handleMessage()asnullmessage.iddereference escaped from the WebSocket event handler as an uncaught errorChange
src/core/cri/deno-cri/chrome.js::_handleMessagemessage.id) and event (message.method) handling unchanged for well-formed protocol messagesEffect
Checklist
I have (if applicable):