Skip to content

FROMLIST: arm64: dts: qcom: shikra-iqs: Add LT9611UXD HDMI audio overlay - #1329

Open
ks5-dev wants to merge 5 commits into
qualcomm-linux:qcom-6.18.yfrom
ks5-dev:topic/shikra_iqs_overlay
Open

ks5-dev wants to merge 5 commits into
qualcomm-linux:qcom-6.18.yfrom
ks5-dev:topic/shikra_iqs_overlay

Conversation

@ks5-dev

@ks5-dev ks5-dev commented Oct 22, 2026

Copy link
Copy Markdown

This series includes patches to:
add the shikra-iqs-lt9611uxd-evk sound card compatible so DT can
describe board-specific audio topology.

Add machine driver support for the Shikra IQS EVK variant that uses the
LT9611UXD HDMI bridge as an I2S audio codec instead of the MAX98091.

Add a device tree overlay for Shikra IQS EVK boards that use the LT9611UXD HDMI bridge as an I2S audio codec instead of the MAX98091.

The overlay reconfigures the sound card compatible to qcom,shikra-iqs-lt9611uxd-sndcard, overrides the primary I2S playback codec to LT9611UXD, disables the capture DAI link, and disables the MAX98091 codec node.

Add a node label to the sound node in shikra-iqs-evk.dts to allow the overlay to reference it, and wire up the new composite DTB in the Makefile.

Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/

CRs-Fixed: 4718588

…k sound card

Add the shikra-iqs-lt9611uxd-evk sound card compatible so DT can
describe board-specific audio topology. This Shikra EVK variant does
not use the MAX98091 codec as the base shikra-iqs does; instead it uses
the LT9611UXD HDMI bridge as an I2S audio codec. Describing these
variants explicitly in DT allows the machine driver to select the
correct DAPM routes, controls, and clocking behavior for each board.

Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
Add a device tree overlay for Shikra IQS EVK boards that use the
LT9611UXD HDMI bridge as an I2S audio codec instead of the MAX98091.

The overlay reconfigures the sound card compatible to
qcom,shikra-iqs-lt9611uxd-sndcard, overrides the primary I2S playback
codec to LT9611UXD, disables the capture DAI link, and disables the
MAX98091 codec node.

Add a node label to the sound node in shikra-iqs-evk.dts to allow the
overlay to reference it, and wire up the new composite DTB in the
Makefile.

Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
Add SNDRV_PCM_FMTBIT_S32_LE to the supported formats for both capture
and playback hardware descriptors, and handle SNDRV_PCM_FORMAT_S32_LE
in q6apm_dai_hw_params() to set bits_per_sample to 32.

Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
…_params fixup

The be_hw_params_fixup callback unconditionally forced S16_LE format for
all backend DAIs. MI2S and DisplayPort DAIs need to negotiate format
freely to support higher bit depths, so skip the format mask for those
DAI IDs and only apply the S16_LE default for the remaining backends.

Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
…le support

Add machine driver support for the Shikra IQS EVK variant that uses the
LT9611UXD HDMI bridge as an I2S audio codec instead of the MAX98091.
The new compatible reuses the generic sc8280xp DAPM widgets and configures
the codec DAI format for I2S with bit/frame clock driven by the codec.

Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
Signed-off-by: Karthik S <karthik.s@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4718588 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4718588

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #1329 — validate-patch

PR: #1329

Verdict Issues Detailed Report
❌ 0 Full report

Final Summary

  1. Lore link present: Yes — but all 5 commits incorrectly link to cover letter 20261022074220.989787-1-karthik.s@oss.qualcomm.com instead of individual patch message-IDs
  2. Lore link matches PR commits: No — PR is based on a different tree state with grouped shikra compatibles and renamed struct type; functional changes match but context differs significantly
  3. Upstream patch status: ⏳ Decision Pending — series posted Oct 22, 2026 (today); no maintainer review or acceptance signals yet
  4. PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1329 - ASoC: qcom: Add Shikra IQS LT9611UXD EVK audio support (5 commits)
Upstream commit: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ✅ All subjects match lore patches
Body preserves rationale ✅ Commit messages faithfully preserved
Fixes tag present/correct N/A No Fixes tags (new feature addition)
Authorship preserved ✅ From: matches lore author for all commits
Backport note (if applicable) N/A FROMLIST prefix used correctly
Link tags correct ❌ All 5 commits link to cover letter instead of individual patch message-IDs

Diff

File Status Notes
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml ❌ Compatible placement differs: lore adds between sdm660 and sdm845 (alphabetical); PR adds between shikra-cqs and shikra-iqs (grouped). Different base tree state.
arch/arm64/boot/dts/qcom/Makefile ⚠️ Context differs (base index 1c86e7e98f55 vs acbfd39d30afc) but change is functionally identical
arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts ⚠️ Context differs (base index 69b0c34ec9c4 vs 181010854f6d6) but change is functionally identical
arch/arm64/boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtso ✅ New file content matches lore exactly
sound/soc/qcom/qdsp6/q6apm-dai.c ⚠️ Context differs (base index 4a0af204ba8d7 vs different) but change is functionally identical
sound/soc/qcom/sc8280xp.c (patch 4/5) ⚠️ Context differs but change is functionally identical
sound/soc/qcom/sc8280xp.c (patch 5/5) ❌ Struct type name differs: lore uses struct qcom_snd_soc_common; PR uses struct snd_soc_common. Different base tree state.

Issues

  1. Link tag error (all 5 commits): All commits link to the cover letter message-ID 20261022074220.989787-1-karthik.s@oss.qualcomm.com instead of their individual patch message-IDs. Correct links should be:

    • Commit 1/5: https://lore.kernel.org/all/20261022074220.989787-2-karthik.s@oss.qualcomm.com/
    • Commit 2/5: https://lore.kernel.org/all/20261022074220.989787-3-karthik.s@oss.qualcomm.com/
    • Commit 3/5: https://lore.kernel.org/all/20261022074220.989787-4-karthik.s@oss.qualcomm.com/
    • Commit 4/5: https://lore.kernel.org/all/20261022074220.989787-5-karthik.s@oss.qualcomm.com/
    • Commit 5/5: https://lore.kernel.org/all/20261022074220.989787-6-karthik.s@oss.qualcomm.com/
  2. Base tree mismatch (commits 1/5 and 5/5): The PR patches are based on a different tree state than the lore patches:

    • Commit 1/5 dt-bindings: Lore patch places the new compatible in pure alphabetical order (between sdm660 and sdm845), while PR groups it with other shikra variants (between shikra-cqs and shikra-iqs). This indicates the PR is based on a tree where shikra compatibles were already added and grouped together.
    • Commit 5/5 machine driver: Lore patch uses struct qcom_snd_soc_common while PR uses struct snd_soc_common, indicating a struct rename occurred in the PR's base tree that is not present in the lore patch's base tree.
  3. Context differences (commits 2/5, 3/5, 4/5): Multiple commits show different base file SHA1 hashes, indicating the PR is based on a significantly different tree state than the lore patches. While the actual code changes are functionally identical, the surrounding context differs.

Upstream Patch Status

Commit Community Verdict
1/5 dt-bindings ⏳ Decision Pending — posted Oct 22, 2026; no maintainer replies yet
2/5 arm64 dts ⏳ Decision Pending — posted Oct 22, 2026; no maintainer replies yet
3/5 q6apm-dai ⏳ Decision Pending — posted Oct 22, 2026; no maintainer replies yet
4/5 sc8280xp fixup ⏳ Decision Pending — posted Oct 22, 2026; no maintainer replies yet
5/5 sc8280xp compat ⏳ Decision Pending — posted Oct 22, 2026; no maintainer replies yet

Dependency Check

  • ✅ All 5 patches in the series are present in the PR
  • ✅ No external dependencies identified
  • ✅ Series is self-contained

qcom-next Presence

Commit Status
1/5 dt-bindings ⚠️ Partial — subject or partial tree evidence found, but full change not verified
2/5 arm64 dts ❌ Missing — no subject, patch-id, or full tree-content match found
3/5 q6apm-dai ⚠️ Partial — subject or partial tree evidence found, but full change not verified
4/5 sc8280xp fixup ✅ Present — all checked added lines are present
5/5 sc8280xp compat ⚠️ Partial — subject or partial tree evidence found, but full change not verified

Integration presence summary: FAIL — 1/5 commits missing from both qcom-next and topics; 3/5 commits only partially verified.

Verdict

Do not merge without correction. The PR has two critical issues:

  1. Incorrect Link tags: All commits link to the cover letter instead of individual patch message-IDs, breaking traceability to upstream review discussions.

  2. Base tree mismatch: The PR is based on a significantly different tree state than the lore patches, resulting in:

    • Different compatible ordering in dt-bindings (grouped vs alphabetical)
    • Different struct type name in machine driver (snd_soc_common vs qcom_snd_soc_common)
    • Multiple context mismatches across files

While the functional changes appear correct, the base tree differences mean this PR is not a faithful representation of the lore patches. The PR appears to be based on a vendor tree with additional changes (shikra variants grouped, struct renamed) that are not present in the upstream tree the lore patches target.

Recommendation

Reject and request rebase. The submitter should:

  1. Fix all Link tags to point to individual patch message-IDs (not the cover letter)
  2. Rebase the series onto the correct upstream base that matches the lore patches
  3. Verify the dt-bindings compatible ordering matches upstream conventions (alphabetical, not grouped)
  4. Verify the struct type name matches the upstream tree (qcom_snd_soc_common)
  5. Re-submit after the lore patches are accepted upstream

Alternatively, if this PR is intentionally targeting a vendor tree with different conventions, the commit messages should document the adaptations made and why they differ from the lore patches.

Final Summary

  1. Lore link present: Yes — but all 5 commits incorrectly link to cover letter 20261022074220.989787-1-karthik.s@oss.qualcomm.com instead of individual patch message-IDs
  2. Lore link matches PR commits: No — PR is based on a different tree state with grouped shikra compatibles and renamed struct type; functional changes match but context differs significantly
  3. Upstream patch status: ⏳ Decision Pending — series posted Oct 22, 2026 (today); no maintainer review or acceptance signals yet
  4. PR present in qcom-next/topics: Fail — 1/5 commits missing from both qcom-next and topics; 3/5 commits only partially verified (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/5 [PATCH 1/5] FROMLIST: ASoC: dt-bindings: qcom,sm8250: Add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial
2/5 [PATCH 2/5] FROMLIST: arm64: dts: qcom: shikra-iqs: Add LT9611UXD missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/5 [PATCH 3/5] FROMLIST: ASoC: qcom: q6apm-dai: Add 32-bit sample format partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial
4/5 [PATCH 4/5] FROMLIST: ASoC: qcom: sc8280xp: Conditionally set S16_LE present - all checked added lines are present skipped - not checked because qcom-next already contains the change present
5/5 [PATCH 5/5] FROMLIST: ASoC: qcom: sc8280xp: Add partial - subject or partial tree evidence found, but full change was not verified partial - subject or partial tree evidence found, but full change was not verified partial

Final Status

overall_status: FAIL
present_commits: 1/5
partial_commits: 3/5
missing_commits: 1/5
topics_checked_for_commits: 4/5
final_summary: PR present in qcom-next/topics: Fail - 1/5 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1329 — checker-log-analyzer

PR: #1329
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39772295184

Checker Result Summary
Checker Result Summary
checkpatch ✅ All 5 commits passed
dt-binding-check ✅ Binding validation passed
dtb-check ❌ Pre-existing tree issues in base shikra platform
sparse-check ✅ No sparse warnings in changed files
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ b4 fetch failed for all 5 commits (lore link issue)
tag-check ⚠️ Cannot determine target branch (network unavailable)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1329 - Add shikra-iqs-lt9611uxd-evk sound card support
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39772295184

Checker Result Summary
checkpatch ✅ All 5 commits passed
dt-binding-check ✅ Binding validation passed
dtb-check ❌ Pre-existing tree issues in base shikra platform
sparse-check ✅ No sparse warnings in changed files
check-uapi-headers ✅ No UAPI changes
check-patch-compliance ❌ b4 fetch failed for all 5 commits (lore link issue)
tag-check ⚠️ Cannot determine target branch (network unavailable)

❌ dtb-check

Root cause: Pre-existing binding issues in the base shikra platform (dma-controller, ethernet, sram) are exposed when building the new overlay dtb.

Failure details:

shikra-iqs-lt9611uxd-evk.dtb: dma-controller@4a00000 (qcom,shikra-gpi-dma): 
  interrupts: [[0, 511, 4, 0], ...] is too long

shikra-iqs-lt9611uxd-evk.dtb: ethernet@5d00000 (qcom,shikra-ethqos): 
  False schema does not allow True
  compatible: ['qcom,shikra-ethqos'] does not contain items matching the given schema
  Unevaluated properties are not allowed ('#address-cells', '#size-cells', 
  'interconnect-names', 'interconnects', 'mdio', 'phy-handle', 'phy-mode', ...)

shikra-iqs-lt9611uxd-evk.dtb: ethernet@5d20000 (qcom,shikra-ethqos): 
  [same errors as ethernet@5d00000]

shikra-iqs-lt9611uxd-evk.dtb: sram@c11e000 (qcom,shikra-imem): 
  pil-sram@94c:compatible: ['qcom,pil-reloc-info'] does not contain items matching the given schema

Analysis:
These are pre-existing tree issues in the base shikra platform, not introduced by this PR. The PR adds only a device tree overlay (shikra-iqs-lt9611uxd-evk.dtso) that modifies the sound card configuration. The dtb-check builds the composite dtb (base + overlay) and reports errors from the base platform:

  1. dma-controller@4a00000 — interrupts array exceeds binding limits (pre-existing)
  2. ethernet@5d00000 / ethernet@5d20000 — Missing binding for qcom,shikra-ethqos compatible (pre-existing)
  3. sram@c11e000 — Missing binding for qcom,pil-reloc-info compatible (pre-existing)

The PR itself only touches:

  • Documentation/devicetree/bindings/sound/qcom,sm8250.yaml (adds new compatible)
  • arch/arm64/boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtso (new overlay)
  • arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts (adds label to sound node)
  • sound/soc/qcom/q6apm-dai.c (adds S32_LE format support)
  • sound/soc/qcom/sc8280xp.c (adds machine driver support)

None of these changes touch the dma-controller, ethernet, or sram nodes.

Fix: These base platform issues should be fixed separately in the shikra base dtsi files:

  • Add/fix binding for qcom,shikra-gpi-dma to allow the current interrupt array length
  • Add binding for qcom,shikra-ethqos or use a fallback compatible
  • Add binding for qcom,pil-reloc-info or remove the node

Reproduce locally:

make -j$(nproc) O=out CHECK_DTBS=y arch/arm64/boot/dts/qcom/shikra-iqs-lt9611uxd-evk.dtb

Recommendation for this PR: These errors are not blockers for this PR since they are pre-existing tree issues. The PR can be merged as-is, and the base platform issues should be addressed in a separate fix.


❌ check-patch-compliance

Root cause: b4 fetch failed for the lore.kernel.org link in all 5 commits.

Failure details:

Checking commit: FROMLIST: ASoC: dt-bindings: qcom,sm8250: Add shikra-iqs-lt9611uxd-evk sound card
Something seems wrong with the provided link. Please verify it
Try below command to run locally-
b4 am --single-message -C -l -3 https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/

[Same error for all 5 commits]

Analysis:
All 5 commits use the same lore link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/

This link points to patch 1/5 of the series, but the checker is trying to fetch it for all 5 commits. The issue is likely one of:

  1. Timing issue: The patch series was posted to lore very recently (2026-10-22 07:42:20 UTC, ~4 hours before CI run at 11:55 UTC). Lore may not have fully indexed the series yet, or b4 may be experiencing transient network issues.

  2. Link format issue: Each commit should link to its specific patch in the series:

    • Commit 1/5 → .../20261022074220.989787-1-...
    • Commit 2/5 → .../20261022074220.989787-2-...
    • Commit 3/5 → .../20261022074220.989787-3-...
    • etc.

    Currently all commits link to -1- (patch 1/5).

Fix:

Option 1 (if timing issue): Re-trigger CI after a few hours to allow lore to fully index the series.

Option 2 (if link format issue): Update each commit's Link: tag to point to the correct patch in the series:

git rebase -i <base_sha>
# For each commit, mark as 'edit', then:
git commit --amend  # Update Link: tag to correct patch number
git rebase --continue

Correct link format:

  • Commit 1: Link: https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/
  • Commit 2: Link: https://lore.kernel.org/all/20261022074220.989787-2-karthik.s@oss.qualcomm.com/
  • Commit 3: Link: https://lore.kernel.org/all/20261022074220.989787-3-karthik.s@oss.qualcomm.com/
  • Commit 4: Link: https://lore.kernel.org/all/20261022074220.989787-4-karthik.s@oss.qualcomm.com/
  • Commit 5: Link: https://lore.kernel.org/all/20261022074220.989787-5-karthik.s@oss.qualcomm.com/

Reproduce locally:

b4 am --single-message -C -l -3 https://lore.kernel.org/all/20261022074220.989787-1-karthik.s@oss.qualcomm.com/

If this succeeds locally, the issue is transient and re-triggering CI should resolve it.


⚠️ tag-check

Status: Cannot determine target branch (GitHub API unavailable).

Analysis:
All 5 commits have the FROMLIST: prefix, which is valid for all branches. However, the tag-check requirement depends on the target branch:

  • If target is qcom-next or qcom-next-staging → tag-check is skipped (no prefix required)
  • If target is any other branch → tag-check is mandatory (all commits must have a valid prefix)

All commits in this PR start with FROMLIST:, so:

  • ✅ PASS if target is any branch other than qcom-next/qcom-next-staging
  • ⏭️ SKIP if target is qcom-next or qcom-next-staging

Recommendation: Verify the target branch. If it's not qcom-next/qcom-next-staging, tag-check passes.


Verdict

2 blockers to address before merge:

  1. check-patch-compliance failure — Likely a timing issue (lore indexing) or incorrect Link tags. Recommend:

    • Re-trigger CI after a few hours, OR
    • Update Link tags to point to the correct patch number in the series (currently all point to patch 1/5)
  2. dtb-check failures — Pre-existing tree issues in base shikra platform. Not a blocker for this PR since the errors are not introduced by these changes. The base platform issues should be fixed separately.

Action items:

  • Fix Link tags (if needed) or re-trigger CI
  • Optionally: file separate issues/PRs to fix the base shikra platform dtb-check errors (dma-controller, ethernet, sram bindings)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants