Skip to content

drm/panel: add Ilitek ILI7807S panel driver - #1326

Open
arpit-dev-geek wants to merge 4 commits into
qualcomm-linux:qcom-6.18.yfrom
arpit-dev-geek:shikra_update
Open

arpit-dev-geek wants to merge 4 commits into
qualcomm-linux:qcom-6.18.yfrom
arpit-dev-geek:shikra_update

Conversation

@arpit-dev-geek

@arpit-dev-geek arpit-dev-geek commented Oct 22, 2026 •

Copy link
Copy Markdown

The ILI7807S panel driver and its DT binding were carried on this branch
as FROMLIST patches taken from the v1 posting. The series has since been
reworked through v4 and merged into mainline, so replace the stale v1
patches with the versions that actually landed.

Reverts:
Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"
Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"

Picked from mainline (v7.3-rc1):
447a76a dt-bindings: display: panel: add Ilitek ILI7807S panel controller
dd7ec83 drm/panel: add Ilitek ILI7807S panel driver

Signed-off-by: Arpit Saini arpit.saini@oss.qualcomm.com
Signed-off-by: Neil Armstrong neil.armstrong@linaro.org
Link: https://patch.msgid.link/20260701-ili7807s-v4-1-c7d76d4780a5@oss.qualcomm.com
qcom-next : dd7ec83, 447a76a
CRs-Fixed: 4718454

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4718454 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4718454

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@arpit-dev-geek arpit-dev-geek changed the title drm/panel: ili7807s: replace v1 FROMLIST with merged upstream version drm/panel: ili7807s: add Ilitek ILI7807S panel driver Oct 22, 2026
@arpit-dev-geek arpit-dev-geek changed the title drm/panel: ili7807s: add Ilitek ILI7807S panel driver drm/panel: add Ilitek ILI7807S panel driver Oct 22, 2026
@qlijarvis

Copy link
Copy Markdown

PR #1326 — validate-patch

PR: #1326

Verdict Issues Detailed Report
⚠️ 3 Full report

Final Summary

  1. Lore link present: Partial — commits 3/4 and 4/4 have valid lore links (https://patch.msgid.link/20260701-ili7807s-v4-*); commits 1/4 and 2/4 are reverts with no lore link (expected)

  2. Lore link matches PR commits: Yes — commits 3/4 and 4/4 are faithful cherry-picks of upstream commits 447a76a and dd7ec83; commit messages, authorship, and diffs match exactly

  3. Upstream patch status: Upstreamed — both commits merged into mainline via drm-next (confirmed by merge commit 4e69c18 "Merge tag 'drm-next-2026-08-20'") and present in topics/baseline (Linux 7.3)

  4. PR present in qcom-next/topics: Fail - 2/4 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1326 - Replace v1 ILI7807S panel driver with v4 mainline version
Upstream commits:

Commit Message

Commit 1/4: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"

Check Status Note
Subject matches upstream N/A Revert commit - no upstream source
Body preserves rationale ✅ Clear explanation: reverting v1 to apply v4
Fixes tag present/correct N/A Not applicable for revert
Authorship preserved ✅ Arpit Saini as author
Backport note (if applicable) N/A Not a backport

Commit 2/4: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"

Check Status Note
Subject matches upstream N/A Revert commit - no upstream source
Body preserves rationale ✅ Clear explanation: reverting v1 to apply v4
Fixes tag present/correct N/A Not applicable for revert
Authorship preserved ✅ Arpit Saini as author
Backport note (if applicable) N/A Not a backport

Commit 3/4: UPSTREAM: dt-bindings: display: panel: add Ilitek ILI7807S panel controller

Check Status Note
Subject matches upstream ✅ Identical to upstream commit 447a76a
Body preserves rationale ✅ Complete match with upstream
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ Arpit Saini matches upstream author
Backport note (if applicable) ✅ (cherry picked from commit 447a76a99e242fd04eaea33ecd9a6d73992e49a0)

Commit 4/4: UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver

Check Status Note
Subject matches upstream ✅ Identical to upstream commit dd7ec83
Body preserves rationale ✅ Complete match with upstream
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ Arpit Saini matches upstream author
Backport note (if applicable) ✅ (cherry picked from commit dd7ec83f456734de8efc115eac671e5add82777a)

Diff

Commit 1/4:

File Status Notes
drivers/gpu/drm/panel/Kconfig ✅ Removes ILI7807S config entry
drivers/gpu/drm/panel/Makefile ✅ Removes ILI7807S build rule
drivers/gpu/drm/panel/panel-ilitek-ili7807s.c ✅ Deletes v1 driver (328 lines)

Commit 2/4:

File Status Notes
Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml ✅ Deletes v1 binding (71 lines)

Commit 3/4:

File Status Notes
Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml ✅ Faithful cherry-pick from 447a76a

Commit 4/4:

File Status Notes
drivers/gpu/drm/panel/Kconfig ✅ Faithful cherry-pick from dd7ec83
drivers/gpu/drm/panel/Makefile ✅ Faithful cherry-pick from dd7ec83
drivers/gpu/drm/panel/panel-ilitek-ili7807s.c ✅ Faithful cherry-pick from dd7ec83 (285 lines)

Upstream Patch Status

Commit Community Verdict
3/4: dt-bindings: display: panel: add Ilitek ILI7807S panel controller ✅ ACKed — merged as 447a76a99e24 in qcom-next (via drm-next → mainline)
4/4: drm/panel: add Ilitek ILI7807S panel driver ✅ ACKed — merged as dd7ec83f4567 in qcom-next (via drm-next → mainline)

Issues

Integration Presence Failure:

  • Commits 1/4 and 2/4 (the revert commits) are missing from qcom-next and topics branches
  • The reverted commits (cc11ce942b72 and afd0e9ce84cd) do not exist in the current qcom-next tree
  • This creates a logical inconsistency: the PR reverts commits that aren't present in the target branch

Root Cause:
The v1 FROMLIST commits being reverted were likely in an older version of qcom-next or a topic branch that has since been rebased/dropped. The current qcom-next already contains the v4 upstream versions (commits 3/4 and 4/4 of this PR).

Verdict

Do not merge — The revert commits (1/4 and 2/4) are attempting to revert commits that don't exist in the current qcom-next branch. The UPSTREAM commits (3/4 and 4/4) are already present in qcom-next as 447a76a99e24 and dd7ec83f4567.

Recommended Action:
Close this PR. The desired end state (v4 ILI7807S driver in the tree) is already achieved in qcom-next. If the v1 commits exist in a different branch that needs cleanup, rebase that branch against current qcom-next instead of merging this PR.

Final Summary

  1. Lore link present: Partial — commits 3/4 and 4/4 have valid lore links (https://patch.msgid.link/20260701-ili7807s-v4-*); commits 1/4 and 2/4 are reverts with no lore link (expected)

  2. Lore link matches PR commits: Yes — commits 3/4 and 4/4 are faithful cherry-picks of upstream commits 447a76a and dd7ec83; commit messages, authorship, and diffs match exactly

  3. Upstream patch status: Upstreamed — both commits merged into mainline via drm-next (confirmed by merge commit 4e69c18 "Merge tag 'drm-next-2026-08-20'") and present in topics/baseline (Linux 7.3)

  4. PR present in qcom-next/topics: Fail — 2/4 commits (the revert commits 1/4 and 2/4) are missing from both qcom-next and topics; the UPSTREAM commits 3/4 and 4/4 are already present in qcom-next, making the reverts unnecessary and the PR redundant

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/4 [PATCH 1/4] Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/4 [PATCH 2/4] Revert "FROMLIST: dt-bindings: display: panel: add Ilitek missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/4 [PATCH 3/4] UPSTREAM: dt-bindings: display: panel: add Ilitek present - exact patch-id match at 447a76a skipped - not checked because qcom-next already contains the change present
4/4 [PATCH 4/4] UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 2/4
partial_commits: 0/4
missing_commits: 2/4
topics_checked_for_commits: 2/4
final_summary: PR present in qcom-next/topics: Fail - 2/4 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1326 — checker-log-analyzer

PR: #1326
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39761331144

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 warning on commit 2 (DT_SPLIT_BINDING)
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits missing required prefix
tag-check ❌ 2 Revert commits missing prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1326 - Revert v1 ILI7807S panel patches and apply v4 UPSTREAM versions
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39761331144
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 1 warning on commit 2 (DT_SPLIT_BINDING)
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits missing required prefix
tag-check ❌ 2 Revert commits missing prefix (mandatory for qcom-6.18.y)

❌ checkpatch

Root cause: Commit 2 reverts a DT binding, triggering DT_SPLIT_BINDING warning.

Failure details:

Commit 07c4f33ee946 ("Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"")
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

07c4f33ee946cf124a32443157ec64c369cbaaa9 total: 0 errors, 1 warnings, 0 checks, 13 lines checked

Analysis: This is a false positive. The warning fires because checkpatch detects a change to Documentation/devicetree/bindings/, but this is a Revert commit that removes a binding file. The original commit that added the binding was split correctly (binding in one patch, driver in another). Reverting them separately maintains that structure. The warning can be safely ignored for revert commits.

Fix: None required — this is expected behavior for a revert commit.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git f46367083aea..da06801ad041

❌ check-patch-compliance

Root cause: Commits 1 and 2 are Revert commits without a required prefix before the word Revert.

Failure details:

Checking commit: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"
Commit summary does not start with a required prefix

Checking commit: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"
Commit summary does not start with a required prefix

Fix: Add a prefix (UPSTREAM:, FROMLIST:, FROMGIT:, or BACKPORT:) before the word Revert in both commit subjects.

Since these are reverting patches that were originally posted to the mailing list (FROMLIST), and the reverts themselves are not upstream commits, the correct prefix is FROMLIST::

git rebase -i f46367083aea   # mark commits 1 and 2 as 'edit'

# For commit 1:
git commit --amend -m "FROMLIST: Revert \"FROMLIST: drm/panel: add Ilitek ILI7807S panel driver\"

This reverts commit cc11ce942b72d04c5fd711dcd3c38c8e5a05d19b.

This was the v1 version posted upstream. Reverting so the final v4
version, as merged into mainline, can be applied in its place.

Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>"

# For commit 2:
git rebase --continue
git commit --amend -m "FROMLIST: Revert \"FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller\"

This reverts commit <sha>.

<original commit body>

Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>"

git rebase --continue

Reproduce locally:

cd kernel
../kernel-checkers/check-patch-compliance.sh --base f46367083aea --head da06801ad041

❌ tag-check

Root cause: Commits 1 and 2 do not start with a required subject-line prefix tag.

Context: The target branch is qcom-6.18.y, which is not qcom-next or qcom-next-staging. Therefore, every commit must have a subject-line prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:).

Failure details:

Commit 8ef44385674e: "Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver""
  ❌ Subject does not start with a required prefix

Commit 07c4f33ee946: "Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller""
  ❌ Subject does not start with a required prefix

Fix: Same as check-patch-compliance — add FROMLIST: before Revert in both commit subjects (see fix above).

Note: This check is distinct from check-patch-compliance. The tag-check enforces that all commits have a prefix (including QCLINUX:, PENDING:, WORKAROUND:), while check-patch-compliance only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:). Both checks fail on the same two commits for the same reason.


Verdict

2 blockers must be fixed before merge:

  1. Commits 1 and 2: Add FROMLIST: prefix before Revert in the subject line (fixes both check-patch-compliance and tag-check failures).
  2. checkpatch warning: Can be ignored — it's a false positive for revert commits.

After fixing the subject lines, all checkers will pass. The changes themselves are clean: reverting v1 patches and applying the final v4 UPSTREAM versions.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: CR Not Eligible for Merge

CR 4718454 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4718454
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

@qlijarvis

Copy link
Copy Markdown

PR #1326 — validate-patch

PR: #1326

Verdict Issues Detailed Report
⚠️ 4 Full report

Final Summary

  1. Lore link present: Partial - commits 3/4 and 4/4 have proper Link: tags; commits 1/4 and 2/4 are reverts (no upstream link expected)

  2. Lore link matches PR commits: Cannot verify - lore mbox files were not fetched by Jarvis despite Link: tags being present in commits 3/4 and 4/4. Manual verification would require network access to lore.kernel.org.

  3. Upstream patch status:

    • Commits 3/4 and 4/4: ✅ Upstreamed - cherry-picked from mainline commits 447a76a and dd7ec83
    • Commits 1/4 and 2/4: N/A - revert commits, not posted upstream
  4. PR present in qcom-next/topics: Fail - 2/4 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1326 - Replace ILI7807S v1 with v4 (mainline version)
Upstream commits:

Summary by Commit

Commit 1/4: FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"

Check Status Note
Lore link present ❌ No Link: tag - revert commits don't require upstream links
Subject format ✅ Proper revert format with FROMLIST: prefix
Body preserves rationale ✅ Explains v1→v4 replacement
Authorship ✅ Arpit Saini (submitter)
Signed-off-by ✅ Present

Commit 2/4: FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"

Check Status Note
Lore link present ❌ No Link: tag - revert commits don't require upstream links
Subject format ✅ Proper revert format with FROMLIST: prefix
Body preserves rationale ✅ Explains v1→v4 replacement
Authorship ✅ Arpit Saini (submitter)
Signed-off-by ✅ Present

Commit 3/4: UPSTREAM: dt-bindings: display: panel: add Ilitek ILI7807S panel controller

Check Status Note
Subject matches upstream ✅ UPSTREAM: prefix added, rest matches
Body preserves rationale ✅ Full description preserved
Reviewed-by tag ✅ Krzysztof Kozlowski present
Authorship preserved ✅ Arpit Saini (original author)
Backport note ✅ (cherry picked from commit 447a76a99e242fd04eaea33ecd9a6d73992e49a0)
Link tag ✅ https://patch.msgid.link/20260701-ili7807s-v4-1-c7d76d4780a5@oss.qualcomm.com

Commit 4/4: UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver

Check Status Note
Subject matches upstream ✅ UPSTREAM: prefix added, rest matches
Body preserves rationale ✅ Full description preserved
Reviewed-by tag ✅ Neil Armstrong present
Authorship preserved ✅ Arpit Saini (original author)
Backport note ✅ (cherry picked from commit dd7ec83f456734de8efc115eac671e5add82777a)
Link tag ✅ https://patch.msgid.link/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com

Diff Comparison

Note: Cannot verify diff faithfulness to upstream lore patches due to network restrictions. Lore evidence was not fetched by Jarvis (lore_evidence/README.md reports "no lore.kernel.org Link tags found", though Link: tags are present in commits 3/4).

File Status Notes
Commits 1-2 (reverts) ⏭️ Revert commits - no upstream comparison needed
Commit 3 dt-bindings YAML ⚠️ Cannot verify against lore - no local mbox available
Commit 4 panel driver ⚠️ Cannot verify against lore - no local mbox available

Issues

Commit Message Issues:

  • None detected. All UPSTREAM commits have proper Link: tags, cherry-pick notes, and preserved authorship.

Revert Commits (1/4, 2/4):

  • Revert commits reference commits cc11ce942b72 and afd0e9ce84cd which are not present in the current qcom-next tree. This is expected if those v1 patches were in a previous state of the tree or a topic branch that has since been rebased/removed.
  • The rationale is clear: replacing v1 with the final v4 version that was merged into mainline.

Integration Presence:

  • ❌ Commits 1/4 and 2/4 (reverts) are missing from both qcom-next and topics
  • ✅ Commits 3/4 and 4/4 (UPSTREAM patches) are present in qcom-next

Verdict

Commits 3/4 and 4/4: These UPSTREAM commits are properly formatted with correct Link: tags, cherry-pick notes, preserved authorship, and review tags. They are already present in qcom-next (447a76a and dd7ec83).

Commits 1/4 and 2/4: These revert commits are not present in qcom-next/topics. This creates a logical inconsistency:

  • If the v1 patches (being reverted) are still in qcom-next, then these reverts should be applied before the v4 patches
  • If the v1 patches are not in qcom-next, then these reverts are unnecessary

Recommendation: Investigate whether commits cc11ce9 and afd0e9c exist in the target integration branch. If they do not exist, commits 1/4 and 2/4 should be dropped from this PR. If they do exist in a topic branch or staging area, verify the merge order to ensure reverts are applied before the v4 patches.

Final Summary

  1. Lore link present: Partial - commits 3/4 and 4/4 have proper Link: tags; commits 1/4 and 2/4 are reverts (no upstream link expected)

  2. Lore link matches PR commits: Cannot verify - lore mbox files were not fetched by Jarvis despite Link: tags being present in commits 3/4 and 4/4. Manual verification would require network access to lore.kernel.org.

  3. Upstream patch status:

    • Commits 3/4 and 4/4: ✅ Upstreamed - cherry-picked from mainline commits 447a76a and dd7ec83
    • Commits 1/4 and 2/4: N/A - revert commits, not posted upstream
  4. PR present in qcom-next/topics: ❌ Fail - 2/4 commits (the revert commits 1/4 and 2/4) are missing from both qcom-next and topics. The UPSTREAM commits 3/4 and 4/4 are already present in qcom-next. This suggests the reverts may be unnecessary or targeting commits that don't exist in the integration tree.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/4 [PATCH 1/4] FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/4 [PATCH 2/4] FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/4 [PATCH 3/4] UPSTREAM: dt-bindings: display: panel: add Ilitek present - exact patch-id match at 447a76a skipped - not checked because qcom-next already contains the change present
4/4 [PATCH 4/4] UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 2/4
partial_commits: 0/4
missing_commits: 2/4
topics_checked_for_commits: 2/4
final_summary: PR present in qcom-next/topics: Fail - 2/4 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1326 — checker-log-analyzer

PR: #1326
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39905989736

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 warning on commit a75c799 (Revert commit)
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits missing Link: tag
tag-check ✅ All commits have valid prefixes

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1326 - Revert and re-add Ilitek ILI7807S panel driver
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39905989736
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 1 warning on commit a75c799 (Revert commit)
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits missing Link: tag
tag-check ✅ All commits have valid prefixes

❌ checkpatch

Root cause: Revert commit a75c799 modifies a DT binding file, triggering checkpatch's DT_SPLIT_BINDING warning.

Failure details:

Commit a75c799e8baa ("FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"")
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

a75c799e8baa6a6c959eec5fa2a0a514a600d3b6 total: 0 errors, 1 warnings, 0 checks, 13 lines checked

Analysis: This is a false positive. The warning is triggered because checkpatch detects a DT binding file change, but this is a revert commit that removes a binding. Revert commits are atomic operations that must undo all changes from the original commit in a single patch. Splitting a revert into multiple patches would break the atomicity of the revert operation and is not standard kernel practice.

Fix: No action required. This is an acceptable false positive for revert commits.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 8b4dfa578ca03113582feb8ab2fa3faa1a63bb33..b49b6d362768ebeaf4b844354e7191a67a04bfea

❌ check-patch-compliance

Root cause: Two FROMLIST: revert commits (ff64f94 and a75c799) are missing the required Link: tag pointing to the upstream mailing list thread.

Failure details:

Checking commit: FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"
No 'Link' found in commit message

Checking commit: FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"
No 'Link' found in commit message

Analysis: The check-patch-compliance checker enforces that all commits with FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: prefixes must include a Link: tag pointing to the upstream source. The two revert commits use the FROMLIST: prefix but do not include a Link: tag.

Fix: Add a Link: tag to each revert commit pointing to the upstream mailing list thread where the revert was posted (or will be posted). If these reverts have not been posted upstream yet, consider one of these options:

  1. If the reverts will be posted upstream: Add the Link: tag once posted, e.g.:

    Link: https://lore.kernel.org/...
    
  2. If the reverts are vendor-only (not posted upstream): Change the prefix from FROMLIST: to QCLINUX: or PENDING:. Note that this will cause check-patch-compliance to fail with a different error (prefix not in allowed list), which is a known limitation of the checker for vendor-only commits.

  3. If reverting an upstream commit that was never merged: Change the prefix to match the original commit's status. Since the original commits being reverted were FROMLIST:, and you're now replacing them with UPSTREAM: versions (commits 3 and 4), these reverts are effectively vendor-only cleanup. Consider using QCLINUX: prefix instead.

Recommended action:

git rebase -i 8b4dfa578ca03113582feb8ab2fa3faa1a63bb33

# For commit ff64f94ed286:
git commit --amend
# Add to commit message body:
# Link: <lore-url-for-revert-or-original-patch>

# For commit a75c799e8baa:
git commit --amend
# Add to commit message body:
# Link: <lore-url-for-revert-or-original-patch>

git rebase --continue

Reproduce locally:

bash ../kernel-checkers/check-patch-compliance.sh --kernel-src . \
  --base 8b4dfa578ca03113582feb8ab2fa3faa1a63bb33 --head <your-branch>

✅ tag-check

Status: PASS

All four commits have valid subject-line prefixes:

  • Commit 1: FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"
  • Commit 2: FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"
  • Commit 3: UPSTREAM: dt-bindings: display: panel: add Ilitek ILI7807S panel controller
  • Commit 4: UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver

The target branch qcom-6.18.y requires all commits to have a valid prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, or WORKAROUND:), and all commits comply.


Verdict

2 blockers to fix before merge:

  1. check-patch-compliance: Add Link: tags to the two FROMLIST: revert commits (ff64f94 and a75c799), or change their prefix to QCLINUX: if they are vendor-only reverts.

  2. checkpatch warning: This is a false positive for revert commits and can be safely ignored. No action required.

Summary: The PR is nearly ready. The primary blocker is the missing Link: tags on the two revert commits. Once those are added (or the prefix is changed to reflect vendor-only status), the PR will be compliant with all checker requirements.

Arpit Saini added 4 commits October 23, 2026 16:31
This reverts commit cc11ce9.

This was the v1 version posted upstream. Reverting so the final v4
version, as merged into mainline, can be applied in its place.

Link: https://lore.kernel.org/r/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
…LI7807S panel controller"

This reverts commit afd0e9c.

This was the v1 version posted upstream. Reverting so the final v4
version, as merged into mainline, can be applied in its place.

Link: https://lore.kernel.org/r/20260701-ili7807s-v4-1-c7d76d4780a5@oss.qualcomm.com
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
…roller

ILI7807S is a DSI display controller used to drive MIPI-DSI panels.
The DLC DLC0697 1080x1920 LCD panel is based on this controller.

The panel requires a reset GPIO, I/O voltage supply (vddi), positive
LCD bias supply (avdd) and negative LCD bias supply (avee). The panel
operates in video burst mode with four data lanes using RGB888 pixel
format.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260701-ili7807s-v4-1-c7d76d4780a5@oss.qualcomm.com
(cherry picked from commit 447a76a)
Add a DRM panel driver for the DLC DLC0697 1080x1920@60Hz MIPI DSI
panel based on the Ilitek ILI7807S display controller.

The panel operates in video burst mode with four data lanes using
RGB888 pixel format.

Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com
(cherry picked from commit dd7ec83)
@qlijarvis

Copy link
Copy Markdown

PR #1326 — validate-patch

PR: #1326

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: Yes — all four commits have lore links (reverts link to v4 patches, UPSTREAM commits link to their own v4 postings)

  2. Lore link matches PR commits: Yes for 3/4 and 4/4 — diff content is faithful to lore v4 patches; N/A for 1/4 and 2/4 (reverts link to replacement patches, not originals being reverted)

  3. Upstream patch status: ✅ ACKed — both v4 patches (commits 3/4 and 4/4) were applied to drm-misc-next by maintainer Neil Armstrong and merged as 447a76a and dd7ec83

  4. PR present in qcom-next/topics: Fail - 2/4 commit(s) are missing from both qcom-next and topics

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: [#1326] Update ILI7807S panel driver to v4 upstream version
Upstream commits:


Analysis by Commit

Commit 1/4: FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"

Type: Revert commit (removes old v1 FROMLIST version)
Lore link: https://lore.kernel.org/r/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com

Check Status Note
Lore link present ✅ Link provided in commit message
Link purpose ⚠️ Links to v4 patch being applied, not the original v1 being reverted
Commit message clarity ✅ Clearly explains reverting v1 to apply v4
Authorship ✅ Arpit Saini (submitter)
Signed-off-by ✅ Present

Note: This is a revert commit removing an old FROMLIST v1 version. The lore link points to the v4 upstream patch that will replace it (commit 4/4), not to the original v1 posting being reverted. This is acceptable for context but unconventional — ideally a revert would reference the original commit being reverted.


Commit 2/4: FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"

Type: Revert commit (removes old v1 FROMLIST version)
Lore link: https://lore.kernel.org/r/20260701-ili7807s-v4-1-c7d76d4780a5@oss.qualcomm.com

Check Status Note
Lore link present ✅ Link provided in commit message
Link purpose ⚠️ Links to v4 patch being applied, not the original v1 being reverted
Commit message clarity ✅ Clearly explains reverting v1 to apply v4
Authorship ✅ Arpit Saini (submitter)
Signed-off-by ✅ Present

Note: Same pattern as commit 1/4 — revert links to replacement v4 patch rather than original v1.


Commit 3/4: UPSTREAM: dt-bindings: display: panel: add Ilitek ILI7807S panel controller

Lore link: https://lore.kernel.org/r/20260701-ili7807s-v4-1-c7d76d4780a5@oss.qualcomm.com
Upstream commit: 447a76a

Commit Message
Check Status Note
Subject matches upstream ✅ Identical (with UPSTREAM: prefix added)
Body preserves rationale ✅ Full description preserved
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ Arpit Saini matches lore From:
Reviewed-by preserved ✅ Krzysztof Kozlowski Reviewed-by present
Backport note ✅ (cherry picked from commit 447a76a99e24...)
Link tag ✅ Uses patch.msgid.link (acceptable variant)
Diff Comparison
File Status Notes
Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml ✅ New file, 71 lines added

Diff analysis: Content matches lore patch v4. The YAML binding file is identical to the upstream version.

Upstream Patch Status

Community verdict: ✅ ACKed — Applied to drm-misc-next
Evidence: Neil Armstrong replied "Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)"
Merged as: 447a76a


Commit 4/4: UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver

Lore link: https://lore.kernel.org/r/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com
Upstream commit: dd7ec83

Commit Message
Check Status Note
Subject matches upstream ✅ Identical (with UPSTREAM: prefix added)
Body preserves rationale ✅ Full description preserved
Fixes tag present/correct N/A No Fixes tag in upstream
Authorship preserved ✅ Arpit Saini matches lore From:
Reviewed-by preserved ✅ Neil Armstrong Reviewed-by present
Backport note ✅ (cherry picked from commit dd7ec83f4567...)
Link tag ✅ Uses patch.msgid.link (acceptable variant)
Diff Comparison
File Status Notes
drivers/gpu/drm/panel/Kconfig ✅ Config entry added, matches upstream
drivers/gpu/drm/panel/Makefile ✅ Build rule added, matches upstream
drivers/gpu/drm/panel/panel-ilitek-ili7807s.c ✅ New driver file, 285 lines, matches upstream

Diff analysis: Content matches lore patch v4. The driver implementation is identical to the upstream version (285 lines vs 328 in the old v1 version being reverted).

Upstream Patch Status

Community verdict: ✅ ACKed — Applied to drm-misc-next
Evidence: Neil Armstrong replied "Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)"
Merged as: dd7ec83


Integration Presence (from integration_presence_report.md)

Commit qcom-next Status topics Status Final
1/4 (Revert driver) ❌ missing ❌ missing missing
2/4 (Revert binding) ❌ missing ❌ missing missing
3/4 (UPSTREAM: binding) ✅ present (447a76a) skipped present
4/4 (UPSTREAM: driver) ✅ present (all lines) skipped present

Integration status: FAIL — 2/4 commits missing from qcom-next/topics


Issues Found

  1. Revert commits not in qcom-next/topics — Commits 1/4 and 2/4 (the FROMLIST reverts) are missing from both qcom-next and the kernel-topics branches. This means the old v1 FROMLIST versions they're trying to revert may not exist in the target integration branch, or the reverts haven't been integrated yet.

  2. Unconventional revert link usage — The revert commits link to the v4 upstream patches being applied rather than the original v1 commits being reverted. While this provides useful context, standard practice is to reference the commit being reverted (either by SHA or by its original lore link).

  3. Prefix inconsistency in revert commits — The revert commits use FROMLIST: prefix, but they're reverting old FROMLIST: commits. A revert of a FROMLIST: commit could arguably use no prefix or Revert "FROMLIST: ..." without a new prefix, since the revert itself isn't from a list.


Verdict

Merge recommendation: ⚠️ Conditional approval with clarification needed

Rationale:

  • ✅ Commits 3/4 and 4/4 are excellent — faithful cherry-picks of accepted upstream patches with proper authorship, trailers, and backport notes. These are already present in qcom-next.

  • ⚠️ Commits 1/4 and 2/4 require verification — The revert commits are not present in qcom-next or topics. Before merging this PR:

    1. Verify that the old v1 FROMLIST commits (cc11ce942b72 and afd0e9ce84cd) actually exist in the target branch
    2. If they don't exist, these revert commits are unnecessary and should be dropped
    3. If they do exist, the reverts are valid but should ideally reference the original v1 lore links for completeness

Suggested action: Check the target integration branch for commits cc11ce942b72d04c5fd711dcd3c38c8e5a05d19b and afd0e9ce84cd94b3a6328cfeb7c0e99a4fc853ed. If present, merge as-is. If absent, drop commits 1/4 and 2/4 and merge only 3/4 and 4/4.


Final Summary

  1. Lore link present: Yes — all four commits have lore links (reverts link to v4 patches, UPSTREAM commits link to their own v4 postings)

  2. Lore link matches PR commits: Yes for 3/4 and 4/4 — diff content is faithful to lore v4 patches; N/A for 1/4 and 2/4 (reverts link to replacement patches, not originals being reverted)

  3. Upstream patch status: ✅ ACKed — both v4 patches (commits 3/4 and 4/4) were applied to drm-misc-next by maintainer Neil Armstrong and merged as 447a76a and dd7ec83

  4. PR present in qcom-next/topics: Partial — 2/4 commits present (the UPSTREAM cherry-picks), 2/4 commits missing (the FROMLIST reverts)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/4 [PATCH 1/4] FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
2/4 [PATCH 2/4] FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing
3/4 [PATCH 3/4] UPSTREAM: dt-bindings: display: panel: add Ilitek present - exact patch-id match at 447a76a skipped - not checked because qcom-next already contains the change present
4/4 [PATCH 4/4] UPSTREAM: drm/panel: add Ilitek ILI7807S panel driver present - all checked added lines are present skipped - not checked because qcom-next already contains the change present

Final Status

overall_status: FAIL
present_commits: 2/4
partial_commits: 0/4
missing_commits: 2/4
topics_checked_for_commits: 2/4
final_summary: PR present in qcom-next/topics: Fail - 2/4 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1326 — checker-log-analyzer

PR: #1326
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39946012159

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 warning on commit 2/4 (DT_SPLIT_BINDING)
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits have content mismatch with upstream Link
tag-check ✅ All commits have valid prefixes
qcom-next-check ⚠️ 2 FROMLIST commits targeting qcom-6.18.y (revert commits)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1326 - Replace ILI7807S panel driver v1 with upstream v4 version
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39946012159
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ❌ 1 warning on commit 2/4 (DT_SPLIT_BINDING)
dt-binding-check ✅ Passed
dtb-check ⏭️ Skipped (no DTS changes)
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ 2 commits have content mismatch with upstream Link
tag-check ✅ All commits have valid prefixes
qcom-next-check ⚠️ 2 FROMLIST commits targeting qcom-6.18.y (revert commits)

❌ checkpatch

Root cause: Commit 2/4 reverts a DT binding file, triggering the DT_SPLIT_BINDING warning.

Failure details:

Commit 4ec9c60f3b96 ("FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"")
WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst

4ec9c60f3b966a1eae4330447f593ed2d735e3b3 total: 0 errors, 1 warnings, 0 checks, 13 lines checked

Analysis: This is a false positive. The warning fires because checkpatch detects a change to Documentation/devicetree/bindings/, but this is a revert commit that removes a binding file. The DT_SPLIT_BINDING rule is meant for new bindings, not reverts. Since this PR is replacing v1 with v4 (commits 3 and 4 add the proper split binding + driver), the overall patch series structure is correct.

Fix: No action needed. This is an acceptable checkpatch warning for a revert commit.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git 113239da311a..360bb93a0eea

❌ check-patch-compliance

Root cause: Commits 1/4 and 2/4 are revert commits whose content differs from the upstream Link because they revert the v1 version, not the v4 version referenced in the Link.

Failure details:

Checking commit: FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"
Change is different from the one mentioned in Link

Checking commit: FROMLIST: Revert "FROMLIST: dt-bindings: display: panel: add Ilitek ILI7807S panel controller"
Change is different from the one mentioned in Link

Analysis: The two revert commits (1/4 and 2/4) reference the v4 upstream series in their Link: trailer:

Link: https://lore.kernel.org/r/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com

However, they are reverting the v1 version that was previously applied to the tree (commit cc11ce942b72), not the v4 version. The checker compares the revert's diff against the v4 patch from lore and finds a mismatch.

This is expected behavior for this PR's workflow:

  1. Revert the old v1 driver/binding (commits 1-2)
  2. Apply the final v4 driver/binding (commits 3-4)

The Link: in the revert commits points to the v4 series to document why the revert is happening (to make room for v4), not to claim the revert itself matches v4.

Fix: Two options:

Option A (Recommended): Update the commit messages of commits 1/4 and 2/4 to clarify the Link points to the replacement series, not the reverted content:

FROMLIST: Revert "FROMLIST: drm/panel: add Ilitek ILI7807S panel driver"

This reverts commit cc11ce942b72d04c5fd711dcd3c38c8e5a05d19b.

This was the v1 version posted upstream. Reverting so the final v4
version, as merged into mainline, can be applied in its place.

The v4 series is linked below for reference.

Link: https://lore.kernel.org/r/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>

Add a sentence like "The v4 series is linked below for reference" to make it explicit that the Link is not claiming content equivalence.

Option B: Remove the Link: trailer from the revert commits entirely, since they are reverting v1, not applying v4. The v4 commits (3/4 and 4/4) already have proper Link: trailers.

Reproduce locally:

# Fetch the v4 patch from lore
b4 am --single-message -C -l -3 https://lore.kernel.org/r/20260701-ili7807s-v4-2-c7d76d4780a5@oss.qualcomm.com -o /tmp/out

# Compare with the revert commit
git format-patch -1 397a15fc50cf --stdout > /tmp/revert.patch
diff <(awk '/^diff/,/^--$/' /tmp/revert.patch | grep -E '^[+-][^+-]') \
     <(awk '/^diff/,/^--$/' /tmp/out/*.mbx | grep -E '^[+-][^+-]')

⚠️ qcom-next-check (informational)

Observation: Commits 1/4 and 2/4 use the FROMLIST: prefix but are targeting qcom-6.18.y, not qcom-next or qcom-next-staging.

Analysis: The FROMLIST: prefix typically indicates a patch posted to the mailing list but not yet merged upstream. However, these are revert commits of a previously applied FROMLIST: patch. The revert commits themselves reference the v4 series (which is now UPSTREAM: as shown in commits 3/4 and 4/4).

Recommendation: Consider changing the prefix of commits 1/4 and 2/4 from FROMLIST: to QCLINUX: or BACKPORT:, since they are vendor-specific revert operations, not patches posted to the mailing list. However, this is a style preference, not a blocker.


Verdict

2 non-blocking issues to address before merge:

  1. checkpatch DT_SPLIT_BINDING warning — False positive on revert commit; acceptable as-is.
  2. check-patch-compliance content mismatch — Expected behavior; revert commits reference v4 for context but revert v1. Recommend clarifying commit message or removing Link: from revert commits.

Overall: The PR structure is sound (revert v1, apply v4). The checker failures are due to the revert commits' Link: trailers pointing to v4 while reverting v1. This can be resolved with a commit message clarification or by removing the Link: from the revert commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants