Skip to content

FROMLIST: wifi: ath12k: Add EHT capabilities to scan probe frame - #1325

Open
GaoleZhangHaha wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
GaoleZhangHaha:qcom-6.18.y
Open

GaoleZhangHaha wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
GaoleZhangHaha:qcom-6.18.y

Conversation

@GaoleZhangHaha

Copy link
Copy Markdown

ath12k hardware scan Probe Request frames do not include the EHT Capabilities element. Without this element, an AP cannot identify the STA as EHT-capable during active scanning and may omit EHT-related information from its Probe Response. This can result in incomplete scan information and prevent userspace from correctly determining the AP's EHT capabilities.

For firmware to include the EHT Capabilities element in scan Probe Request frames, two conditions are required:

  • The scan channel must have WMI_CHAN_INFO_ALLOW_EHT set, which allows firmware to add the EHT Capabilities element to Probe Request frames.
  • The EHT Capabilities element must be configured on the vdev through WMI_VDEV_SET_IE_CMDID, so firmware can use it when building Probe Request frames.

Set WMI_CHAN_INFO_ALLOW_EHT for channels when 11be is supported by firmware and not disabled by ACPI. Also configure the EHT Capabilities element before each hardware scan when the element is present in the mac80211 scan IE buffer.

Firmware retains the configured element in the vdev context until it is replaced or the vdev is deleted. However, ath12k scans may either reuse an already started vdev or create a temporary scan vdev that is cleaned up after scan completion. Sending WMI_VDEV_SET_IE_CMDID for each scan request ensures correct behavior in both cases.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3

Link: https://lore.kernel.org/all/20261009095538.2718979-1-gaole.zhang@oss.qualcomm.com/

CRs-Fixed: 4599002

ath12k hardware scan Probe Request frames do not include the EHT
Capabilities element. Without this element, an AP cannot identify the
STA as EHT-capable during active scanning and may omit EHT-related
information from its Probe Response. This can result in incomplete scan
information and prevent userspace from correctly determining the AP's
EHT capabilities.

For firmware to include the EHT Capabilities element in scan Probe
Request frames, two conditions are required:

  - The scan channel must have WMI_CHAN_INFO_ALLOW_EHT set, which allows
    firmware to add the EHT Capabilities element to Probe Request frames.
  - The EHT Capabilities element must be configured on the vdev through
    WMI_VDEV_SET_IE_CMDID, so firmware can use it when building Probe
    Request frames.

Set WMI_CHAN_INFO_ALLOW_EHT for channels when 11be is supported by
firmware and not disabled by ACPI. Also configure the EHT Capabilities
element before each hardware scan when the element is present in the
mac80211 scan IE buffer.

Firmware retains the configured element in the vdev context until it is
replaced or the vdev is deleted. However, ath12k scans may either reuse
an already started vdev or create a temporary scan vdev that is cleaned
up after scan completion. Sending WMI_VDEV_SET_IE_CMDID for each scan
request ensures correct behavior in both cases.

Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3

Signed-off-by: Gaole Zhang <gaole.zhang@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4599002 on any of the following entities:

Entities:

  • kernel.qli.2.0

CR: 4599002

Please ensure the CR has a change task associated with at least one of the entities for this branch.

@qlijarvis

Copy link
Copy Markdown

PR #1325 — validate-patch

PR: #1325

Verdict Issues Detailed Report
❌ 8 Full report

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix; patch appears to be new ath12k functionality for EHT scan capabilities
  4. PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence
Verdict: ❌ — click to expand

🔍 Patch Validation

PR: #1325 - wifi: ath12k: Add EHT capabilities to scan probe frame
Upstream commit: (none found)
Verdict: ❌ FAIL

Commit Message

Check Status Note
Subject matches upstream ❌ No upstream link to compare against
Body preserves rationale N/A No upstream source
Fixes tag present/correct ✅ No Fixes tag needed (new feature)
Authorship preserved N/A No upstream source
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
drivers/net/wireless/ath/ath12k/core.h ⚠️ Cannot verify against upstream - no lore link
drivers/net/wireless/ath/ath12k/mac.c ⚠️ Cannot verify against upstream - no lore link
drivers/net/wireless/ath/ath12k/reg.c ⚠️ Cannot verify against upstream - no lore link
drivers/net/wireless/ath/ath12k/wmi.c ⚠️ Cannot verify against upstream - no lore link
drivers/net/wireless/ath/ath12k/wmi.h ⚠️ Cannot verify against upstream - no lore link

Issues

Missing upstream attribution:

  • The commit has no lore.kernel.org link and no vendor prefix (UPSTREAM:, FROMLIST:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:)
  • Without a prefix or lore link, the upstream status and origin of this patch cannot be determined
  • If this is a new patch being developed for upstream submission, it should use PENDING: or FROMLIST: prefix
  • If this is vendor-only code not intended for upstream, it should use QCLINUX: prefix
  • If this has already been posted to a mailing list, it must include a Link: https://lore.kernel.org/... tag

Integration presence concern:

  • According to integration_presence_report.md, this commit shows only "partial" evidence in qcom-next
  • The report states: "partial - subject or partial tree evidence found, but full change was not verified"
  • This suggests the commit may exist in a different form or may be incomplete in the integration branch

Verdict

Do not merge without correction. This patch lacks the required upstream attribution metadata. The commit must be updated to include either:

  1. A Link: https://lore.kernel.org/r/<message-id> tag if the patch has been posted to a mailing list, OR
  2. An appropriate prefix in the subject line:
    • FROMLIST: if posted to upstream mailing list but not yet merged
    • PENDING: if work-in-progress, not yet posted upstream
    • QCLINUX: if vendor-only code not intended for upstream submission
    • UPSTREAM: if already merged into Linus's tree (with lore/git.kernel.org link)
    • BACKPORT: if backporting an upstream commit with modifications (with lore link)

Additionally, the "partial" integration presence status should be investigated to ensure the commit is not duplicating or conflicting with existing changes in qcom-next.

Final Summary

  1. Lore link present: No — no lore.kernel.org link found in commit message
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: Unknown — cannot determine without lore link or vendor prefix; patch appears to be new ath12k functionality for EHT scan capabilities
  4. PR present in qcom-next/topics: Partial — integration_presence_report.md shows "partial - subject or partial tree evidence found, but full change was not verified" (1/1 commits with partial evidence only)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] wifi: ath12k: Add EHT capabilities to scan probe frame partial - subject or partial tree evidence found, but full change was not verified missing - no subject, patch-id, or full tree-content match found partial

Final Status

overall_status: PARTIAL
present_commits: 0/1
partial_commits: 1/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Partial - 1/1 commit(s) only have partial integration evidence

@qlijarvis

Copy link
Copy Markdown

PR #1325 — checker-log-analyzer

PR: #1325
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39735029800

Checker Result Summary
Checker Result Summary
checkpatch ❌ 1 warning: long line in commit body
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No DTS changes
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Subject missing required prefix (mandatory for qcom-6.18.y)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1325 - wifi: ath12k: Add EHT capabilities to scan probe frame
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39735029800

Checker Result Summary
checkpatch ❌ 1 warning: long line in commit body
dt-binding-check ⏭️ No DT binding changes
dtb-check ⏭️ No DTS changes
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ Missing required prefix
tag-check ❌ Subject missing required prefix (mandatory for qcom-6.18.y)

❌ checkpatch

Root cause: Commit body line exceeds 75 characters (Tested-on: line is 91 chars).

Failure details:

WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#33: 
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3

ab1e5273c7e9c86da47426829e61c47c17c76bff total: 0 errors, 1 warnings, 0 checks, 186 lines checked

Fix: Wrap the Tested-on: line at 75 characters:

git rebase -i f46367083aea   # mark commit as 'edit'
# Edit commit message to wrap the Tested-on line:
# Tested-on: WCN7850 hw2.0 PCI
#   WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3
git commit --amend
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git f46367083aea..ab1e5273c7e9

❌ check-patch-compliance

Root cause: Commit subject does not start with a required prefix (FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT:).

Failure details:

Checking commit: wifi: ath12k: Add EHT capabilities to scan probe frame
Commit summary does not start with a required prefix

Fix: Add the appropriate prefix to the commit subject. Since this appears to be a new patch:

git rebase -i f46367083aea   # mark commit as 'edit'
git commit --amend -m "FROMLIST: wifi: ath12k: Add EHT capabilities to scan probe frame"
# Keep the rest of the commit body unchanged
git rebase --continue

If this patch has been posted to a mailing list, also add a Link: tag pointing to the lore.kernel.org URL in the commit body.

Reproduce locally:

# The check-patch-compliance checker validates:
# 1. Subject starts with FROMLIST:/FROMGIT:/UPSTREAM:/BACKPORT:
# 2. Link: tag present in commit body
# 3. Content matches the linked upstream patch
# 4. Author matches the upstream patch

❌ tag-check

Root cause: PR targets qcom-6.18.y branch, which requires all commits to have a subject prefix tag, but commit ab1e5273c7e9 has no prefix.

Failure details:

Commit ab1e5273c7e9 ("wifi: ath12k: Add EHT capabilities to scan probe frame"):
subject line does not start with a required prefix.

Target branch: qcom-6.18.y (NOT qcom-next or qcom-next-staging)
All branches except qcom-next and qcom-next-staging require one of:
FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

Fix: Add the appropriate prefix based on the patch origin:

Situation Prefix to use
Posted to lore.kernel.org, not yet merged FROMLIST:
In a maintainer git tree FROMGIT:
Merged into Linus's tree UPSTREAM:
Backported with modifications BACKPORT:
Vendor-only, no upstream QCLINUX:
git rebase -i f46367083aea   # mark commit as 'edit'
git commit --amend -m "FROMLIST: wifi: ath12k: Add EHT capabilities to scan probe frame"
# Keep the rest of the commit body unchanged
git rebase --continue

Note: This is the same fix as check-patch-compliance — adding the prefix will resolve both failures.

Reproduce locally:

# Check all commits in the PR for required prefix:
git log f46367083aea..ab1e5273c7e9 --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'; then
    echo "MISSING prefix: $sha $subject"
  fi
done

Verdict

2 blockers must be fixed before merge:

  1. Add required subject prefix — The commit subject must start with FROMLIST: (or another valid prefix). This is mandatory for the qcom-6.18.y branch and will fix both check-patch-compliance and tag-check failures.

  2. Wrap long commit body line — The Tested-on: line exceeds 75 characters and should be wrapped.

Recommended action:

git rebase -i f46367083aea
# Mark commit as 'edit'
# 1. Amend subject: "FROMLIST: wifi: ath12k: Add EHT capabilities to scan probe frame"
# 2. Wrap Tested-on line at 75 chars
git commit --amend
git rebase --continue
git push --force-with-lease

After these fixes, re-trigger CI to verify all checkers pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants