Skip to content

QCLINUX: qcom.config: Disable Menu governor for CPUidle - #1320

Open
smankad-oss wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
smankad-oss:disable_menu_qli2.0
Open

smankad-oss wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
smankad-oss:disable_menu_qli2.0

Conversation

@smankad-oss

@smankad-oss smankad-oss commented Oct 21, 2026 •

Copy link
Copy Markdown

Menu governor still stays as default governor when both are compiled in due to menu having higher rating than teo.

Teo governor helps with power and performance evaluation. But to make it as default we will need to disable Menu governor.

Disable menu governor for CPUidle.

CRs-Fixed: 4691639

Menu governor still stays as default governor when both are compiled in due
to menu having higher rating than teo.

Teo governor helps with power and performance evaluation. But to make it as
default we will need to disable Menu governor.

Disable menu governor for CPUidle.

Signed-off-by: Sneh Mankad <sneh.mankad@oss.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1320 — validate-patch

PR: #1320

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1320 - QCLINUX: qcom.config: Disable Menu governor for CPUidle
Upstream commit: N/A (vendor-only QCLINUX: commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale ✅ Clear explanation of why Menu governor needs to be disabled
Fixes tag present/correct N/A Config change, no bug fix
Authorship preserved ✅ Sneh Mankad correctly attributed
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/configs/qcom.config ✅ Single-line config change disabling CONFIG_CPU_IDLE_GOV_MENU

Issues

  • ⚠️ Integration presence: Commit is missing from both qcom-next and topics branches (per integration_presence_report.md). This is expected for new vendor-only changes but should be merged to qcom-next after PR approval.

Verdict

Merge as-is. This is a valid vendor-only configuration change with clear rationale. The commit is not yet in qcom-next/topics, which is expected for a new PR awaiting merge.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (expected for new PR; will be present after merge)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: qcom.config: Disable Menu governor for CPUidle missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1320 — checker-log-analyzer

PR: #1320
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39582403383

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTS changes
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ✅ Valid prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1320 - QCLINUX: qcom.config: Disable Menu governor for CPUidle
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39582403383
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ⏭️ No DTS changes
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ✅ Valid prefix present

❌ check-patch-compliance

Root cause: The commit uses the QCLINUX: prefix, which is not in the checker's allowed list.

Failure details:

Checking commit: QCLINUX: qcom.config: Disable Menu governor for CPUidle
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to lore.kernel.org)
  • FROMGIT: (from a maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The commit uses QCLINUX:, which is a vendor-internal prefix used in the Qualcomm Linux kernel tree for vendor-only changes that have no upstream equivalent. This is a known limitation of the check-patch-compliance checker — it enforces upstream-linkable prefixes only and will always fail for QCLINUX: and PENDING: prefixed commits.

This is not a patch defect. The commit is correctly tagged as QCLINUX: because:

  1. It modifies arch/arm64/configs/qcom.config, a Qualcomm vendor-specific config file
  2. This change is vendor-specific and not intended for upstream submission
  3. The QCLINUX: prefix accurately reflects the nature of the change

Fix options:

Option 1 (Recommended): Accept the checker failure as expected behavior for vendor-only commits. The QCLINUX: prefix is correct and should not be changed.

Option 2: If you want the checker to pass, you would need to:

  • Post the patch to a mailing list (even if not appropriate for upstream)
  • Change prefix to FROMLIST: and add a Link: tag
  • However, this would be misleading since the change is vendor-specific

Reproduce locally:

cd kernel
git log b1c712400a3d..89560716624d --format="%s" | grep -v "^FROMLIST:\|^FROMGIT:\|^UPSTREAM:\|^BACKPORT:"

Verdict

1 known limitation (not a blocker) — The check-patch-compliance failure is expected for QCLINUX:-prefixed commits. This is a vendor-only config change correctly tagged with QCLINUX:. The checker limitation does not indicate a patch defect.

Recommendation: Merge as-is. The commit is properly formatted, passes checkpatch, and uses the correct prefix for a vendor-specific change. The check-patch-compliance failure is a known checker limitation for vendor-only commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants