Skip to content

PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging… - #1313

Open
saikarth08 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
manikanta-qli:mmanikan/hamoa-qps615-6.18
Open

saikarth08 wants to merge 1 commit into
qualcomm-linux:qcom-6.18.yfrom
manikanta-qli:mmanikan/hamoa-qps615-6.18

Conversation

@saikarth08

@saikarth08 saikarth08 commented Oct 19, 2026 •

Copy link
Copy Markdown

Add hamoa-evk-staging.dtso for the QPS615 m.2 e-key daughter card.
When installed, the QPS615 PCIe switch replaces the direct WLAN connection.

The overlay describes dual Ethernet (TC956X) at QPS615 downstream port 4 (pci@4,0, bus 5 dev 0 fn0/fn1)

QLIJIRA: 223
QLI 0.0 PR: qualcomm-linux/kernel-topics#2070
CRs-fixed: 4714771

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

3 similar comments
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

Comment thread arch/arm64/boot/dts/qcom/Makefile Outdated

dtb-$(CONFIG_ARCH_QCOM) += glymur-staging.dtbo

dtb-$(CONFIG_ARCH_QCOM) += hamoa-evk-staging.dtbo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move hamoa-evk-staging.dtbo after hamoa-staging.dtbo

@manikanta-qli
manikanta-qli force-pushed the mmanikan/hamoa-qps615-6.18 branch from d4381bb to cbfe1b1 Compare October 19, 2026 09:52
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1313 — validate-patch

PR: #1313

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
Upstream commit: N/A (PENDING: prefix — work-in-progress, not yet posted upstream)
Verdict: ⏭️ SKIPPED (vendor-only commit)

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix — no upstream source to compare
Body preserves rationale N/A No upstream commit message to validate against
Fixes tag present/correct N/A Not applicable for new feature addition
Authorship preserved ✅ Author: Manikanta Mylavarapu mmanikan@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ⏭️ Adds hamoa-evk-staging.dtbo build target
arch/arm64/boot/dts/qcom/hamoa-evk-staging.dtso ⏭️ New staging overlay for QPS615 M.2 Ethernet on hamoa-evk

Issues

None — this is a vendor-specific staging overlay with PENDING: prefix, indicating work-in-progress that has not been posted upstream. No lore link is expected or required for this commit type.

Verdict

This commit cannot be validated against upstream sources as it is marked PENDING: (work-in-progress, not yet posted to mailing lists). The validate-patch skill explicitly excludes PENDING:, QCLINUX:, and WORKAROUND: prefixed commits from validation as they are vendor-only changes with no upstream lore link by design.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — integration_presence_report.md shows this commit is missing from both qcom-next and topics (1/1 commits missing). This is expected for a PENDING: commit that represents new work-in-progress.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1313 — checker-log-analyzer

PR: #1313
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39230774254

Checker Result Summary
Checker Result Summary
checkpatch ❌ Missing commit description
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ PENDING: prefix not allowed
tag-check ⚠️ PENDING: is valid but triggers compliance failure

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39230774254

Checker Result Summary
checkpatch ❌ Missing commit description
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No UAPI changes
check-patch-compliance ❌ PENDING: prefix not allowed
tag-check ⚠️ PENDING: is valid but triggers compliance failure

❌ checkpatch

Root cause: Commit has no description body between the subject line and Signed-off-by: trailer.

Failure details:

WARNING: Missing commit description - Add an appropriate one

d4381bb79caf68c8fc771b7a11cb1367de9f3325 total: 0 errors, 1 warnings, 0 checks, 95 lines checked

Commit d4381bb79caf ("PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay") has style problems, please review.

Fix: Add a commit body describing what the patch does and why. For example:

git rebase -i b1c712400a3d970e06409c117c686b2451aaccb9   # mark commit as 'edit'
git commit --amend
# In the editor, add a description between the subject and Signed-off-by:
# Example:
#   PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
#
#   Add a device tree overlay for the Hamoa EVK board with QPS615 M.2
#   Ethernet adapter. The QPS615 PCIe switch occupies the M.2 E-key slot,
#   replacing the typical WLAN chip configuration.
#
#   Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git b1c712400a3d970e06409c117c686b2451aaccb9..d4381bb79caf68c8fc771b7a11cb1367de9f3325

❌ check-patch-compliance

Root cause: The PENDING: prefix is not in the allowed list of upstream-linkable prefixes.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The PENDING: prefix indicates work-in-progress that has not been posted upstream. This is a known limitation of the checker — it enforces upstream-linkable commits only.

Fix options:

  1. If this patch has been posted to a mailing list:

    • Change prefix to FROMLIST:
    • Add Link: <lore-url> to the commit body
  2. If this is vendor-only / work-in-progress:

    • The checker will always fail for PENDING: commits
    • This is expected behavior for staging/vendor-specific changes
    • Consider whether this commit should target a branch that accepts vendor commits

Note: The PENDING: prefix is valid for internal use but will always trigger this checker failure. If the target branch is not qcom-next or qcom-next-staging, all commits require upstream-linkable prefixes.


Verdict

2 blockers to fix:

  1. checkpatch: Add commit description body (mandatory fix)
  2. check-patch-compliance: PENDING: prefix limitation (expected for vendor/staging commits)

Recommendation:

  • Fix the missing commit description (blocker Create qualcomm-linux-organization-repolinter.yml #1)
  • For blocker Adding Email Checker  #2: If this is genuinely a work-in-progress staging overlay with no upstream equivalent, the check-patch-compliance failure is expected and can be acknowledged as a known limitation. If the patch has been or will be posted upstream, change the prefix to FROMLIST: and add the Link: trailer.

@qlijarvis

Copy link
Copy Markdown

PR #1313 — validate-patch

PR: #1313

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
Upstream commit: N/A (PENDING: prefix — vendor work-in-progress)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix — no upstream source
Body preserves rationale N/A PENDING: prefix — no upstream source
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved ✅ Author: Manikanta Mylavarapu mmanikan@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds hamoa-evk-staging.dtbo build target
arch/arm64/boot/dts/qcom/hamoa-evk-staging.dtso ✅ New staging overlay for QPS615 M.2 Ethernet on hamoa-evk

Issues

None. This is a properly formatted vendor-only staging overlay commit.

Verdict

Merge as-is. This is a correctly prefixed PENDING: commit for vendor-specific staging work. No upstream lore link is required or expected for this type of commit.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (expected for new PENDING: work being proposed via this PR)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1313 — checker-log-analyzer

PR: #1313
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39233587997

Checker Result Summary
Checker Result Summary
checkpatch ❌ Missing commit description
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not allowed
tag-check ❌ PENDING: not a valid prefix for qcom-6.18.y

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1313 — PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39233587997

Checker Result Summary
checkpatch ❌ Missing commit description
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not allowed
tag-check ❌ PENDING: not a valid prefix for qcom-6.18.y

❌ checkpatch

Root cause: Commit message body is empty — only subject line and Signed-off-by: present.

Failure details:

WARNING: Missing commit description - Add an appropriate one

cbfe1b1cf9fedd32d012c47169594f9964039d81 total: 0 errors, 1 warnings, 0 checks, 98 lines checked

Commit cbfe1b1cf9fe ("PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay") has style problems, please review.

Fix: Add a commit body describing what the patch does and why. For example:

git rebase -i b1c712400a3d   # mark commit as 'edit'
git commit --amend
# Add body text like:
#   Add a device tree overlay for the hamoa-evk board with the QPS615
#   M.2 Ethernet adapter installed. The QPS615 PCIe switch occupies the
#   M.2 E-key slot, replacing the WLAN chip.
git rebase --continue

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git b1c712400a3d..cbfe1b1cf9fe

❌ check-patch-compliance

Root cause: PENDING: is not in the allowed prefix list for check-patch-compliance.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay
Commit summary does not start with a required prefix

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: — patch posted to lore.kernel.org
  • FROMGIT: — patch taken from a maintainer git tree
  • UPSTREAM: — patch merged into Linus's mainline
  • BACKPORT: — upstream patch backported with modifications

PENDING: is a vendor-internal prefix used for work-in-progress commits that have not been posted upstream. The checker will always fail for PENDING: commits — this is a known limitation.

Fix: If this patch has been posted to a mailing list, change the prefix to FROMLIST: and add a Link: trailer pointing to the lore.kernel.org URL. If it's vendor-only and not posted, the checker will continue to fail — this is expected behavior for vendor-only commits.


❌ tag-check

Root cause: The target branch is qcom-6.18.y, which requires every commit to have a valid subject-line prefix. PENDING: is not a valid prefix for this branch.

Failure details:

Commit cbfe1b1cf9fe ("PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay")
Subject line starts with "PENDING:" which is not a valid prefix for branch qcom-6.18.y.

All branches except qcom-next and qcom-next-staging require one of these prefixes:

  • FROMLIST: — posted to mailing list
  • FROMGIT: — from a maintainer tree
  • UPSTREAM: — merged into mainline
  • BACKPORT: — backported with modifications
  • QCLINUX: — vendor-only change
  • WORKAROUND: — temporary fix

PENDING: is not in the allowed list.

Fix: Choose the correct prefix based on the patch origin:

git rebase -i b1c712400a3d   # mark commit as 'edit'

# If this patch has been posted to lore.kernel.org:
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay"

# OR if this is a vendor-only change with no upstream equivalent:
git commit --amend -m "QCLINUX: arm64: dts: qcom: hamoa-evk: add QPS615 M.2 Ethernet staging overlay"

git rebase --continue

Note: If you change to QCLINUX:, the check-patch-compliance checker will still fail (it only accepts upstream-linkable prefixes), but tag-check will pass. If you change to FROMLIST:, you must also add a Link: trailer to the commit body pointing to the lore.kernel.org URL.


Verdict

3 blockers must be fixed before merge:

  1. checkpatch — Add a commit message body describing the change
  2. check-patch-compliance — Change prefix from PENDING: to an allowed prefix (FROMLIST: if posted upstream, or accept the failure if vendor-only)
  3. tag-check — Change prefix from PENDING: to a valid prefix for qcom-6.18.y (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, or WORKAROUND:)

Recommended action: If this patch has been posted to a mailing list, change the prefix to FROMLIST:, add a Link: trailer, and add a commit body. If it's vendor-only, change to QCLINUX: and add a commit body (note: check-patch-compliance will still fail for QCLINUX:, which is expected).

@manikanta-qli
manikanta-qli force-pushed the mmanikan/hamoa-qps615-6.18 branch from cbfe1b1 to 7099613 Compare October 19, 2026 10:51
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@qlijarvis

Copy link
Copy Markdown

PR #1313 — validate-patch

PR: #1313

Verdict Issues Detailed Report
N/A 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

Note: The PENDING: prefix is used for vendor-specific work-in-progress changes that are not yet ready for upstream submission. This skill only validates patches against lore.kernel.org sources. For PENDING: commits, standard code review and internal testing processes apply instead of upstream validation.

Verdict: N/A — click to expand

🔍 Patch Validation

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Upstream commit: N/A
Verdict: ⏭️ SKIP (validation not applicable)

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix — no upstream source
Body preserves rationale N/A PENDING: prefix — no upstream source
Fixes tag present/correct N/A No Fixes tag; not a bugfix
Authorship preserved N/A PENDING: prefix — no upstream source
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ⏭️ PENDING: commit — validation not applicable
arch/arm64/boot/dts/qcom/hamoa-evk-staging.dtso ⏭️ PENDING: commit — validation not applicable

Verdict

This commit uses the PENDING: prefix, indicating work-in-progress that has not been posted upstream. No lore.kernel.org link is expected or required. Validation against upstream sources is not applicable.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: No — commit is missing from both qcom-next and topics (per integration_presence_report.md: "missing - no subject, patch-id, or full tree-content match found")

Note: The PENDING: prefix is used for vendor-specific work-in-progress changes that are not yet ready for upstream submission. This skill only validates patches against lore.kernel.org sources. For PENDING: commits, standard code review and internal testing processes apply instead of upstream validation.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1313 — checker-log-analyzer

PR: #1313
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39240585404

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ DTB validation passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ Valid prefix present

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39240585404

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ DTB validation passed
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ✅ Valid prefix present

❌ check-patch-compliance

Root cause: Commit uses PENDING: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The commit subject starts with PENDING:, which indicates work-in-progress code not yet posted upstream. However, check-patch-compliance only accepts upstream-linkable prefixes:

Accepted by check-patch-compliance Not accepted
FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT: QCLINUX:, PENDING:, WORKAROUND:

Fix options:

  1. If this patch has been posted to a mailing list:

    • Change prefix to FROMLIST:
    • Add Link: <lore-url> to the commit body
    git rebase -i b1c712400a3d
    # mark commit as 'edit'
    git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay"
    # Add Link: line to commit body
    git rebase --continue
  2. If this is vendor-only code not posted upstream:

    • The checker will always fail for PENDING: commits
    • This is expected behavior for work-in-progress vendor code
    • Consider merging with maintainer approval despite the checker failure

Note: The tag-check (which validates that all commits have a valid prefix for non-qcom-next branches) passes because PENDING: is a valid prefix in the broader tag taxonomy. Only check-patch-compliance rejects it.

Reproduce locally:

cd /path/to/kernel
bash /path/to/kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base b1c712400a3d970e06409c117c686b2451aaccb9 \
  --head 709961360750f440a5d0847dad8a0d2502b532eb

Verdict

1 known limitation blocker — The PENDING: prefix is not accepted by check-patch-compliance. If this is genuinely work-in-progress code not posted upstream, this failure is expected and can be merged with maintainer approval. If the patch has been posted to lore, change the prefix to FROMLIST: and add a Link: tag.

@lumag Dmitry Baryshkov (lumag) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the DT, keeping only the Ethernet in the staging file. Submit the rest of the changes upstream

@qlijarvis

Copy link
Copy Markdown

PR #1313 — validate-patch

PR: #1313

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Upstream commit: N/A (PENDING: prefix — not yet posted upstream)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix — no upstream source to compare
Body preserves rationale ✅ Clear description of QPS615 PCIe switch topology and Ethernet overlay
Fixes tag present/correct N/A New feature addition, no Fixes tag required
Authorship preserved N/A No upstream source to verify against
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds hamoa-evk-staging.dtbo build target
arch/arm64/boot/dts/qcom/hamoa-evk-staging.dtso ✅ New overlay file with QPS615 PCIe switch and Ethernet configuration

Issues

  • Integration presence: Commit is missing from both qcom-next and kernel-topics branches. For a PENDING commit, this may be expected if it's genuinely work-in-progress, but it should be tracked for eventual integration.

Verdict

This is a vendor-specific staging overlay with PENDING: prefix, indicating work-in-progress not yet posted upstream. The commit message is clear and the diff is well-structured. However, the commit is not present in qcom-next or topics branches, which may indicate it needs to be integrated into the appropriate topic branch before merging to the main integration branch.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — PENDING: work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit(s) missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 1a0586064ee1fbcefe49b6382ee17a236c590879
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1313 — checker-log-analyzer

PR: #1313
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39736143461

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ❌ PENDING: prefix not valid for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39736143461
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ❌ PENDING: prefix not valid for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: The commit uses PENDING: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker enforces a strict subset of upstream-linkable prefixes and does not accept PENDING:, QCLINUX:, or WORKAROUND: tags. This is a known limitation of the checker — it only validates commits that have an upstream link.

According to the skill's reference documentation (Section 7):

Invalid prefixes that trigger this failure:

Prefix used Why it fails Correct action
PENDING: Not in the allowed list Use FROMLIST: if posted, or QCLINUX: if vendor-only (but see note)

Note: PENDING: indicates work-in-progress that has not been posted upstream. The checker will always fail for such commits because it cannot validate an upstream link.

Fix:

If this patch has been posted to a mailing list (lore.kernel.org):

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay

[original commit body]

Link: https://lore.kernel.org/...
Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>"
git rebase --continue

If this patch is vendor-only and will not be posted upstream:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay

[original commit body]

Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>"
git rebase --continue

Note: Using QCLINUX: will still cause check-patch-compliance to fail (known checker limitation), but it correctly documents the patch's vendor-only status.

Reproduce locally:

cd /path/to/kernel
bash ../kernel-checkers/check-patch-compliance.sh \
  --kernel-src . \
  --base f46367083aeae92dacbf35b714faf4c66cc9b7dd \
  --head 82bc62baa85838c8aeb5e0d0562957a3559007b7

❌ tag-check

Root cause: The target branch is qcom-6.18.y (not qcom-next or qcom-next-staging), which requires every commit to start with a valid prefix tag. PENDING: is not a valid prefix for this branch.

Failure details:

Commit 82bc62baa858 ("PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay"): subject line uses PENDING: prefix.

Analysis:

According to the skill's Step 2.7 (tag-check):

Every commit merged into any branch other than qcom-next or qcom-next-staging must start its subject line with one of the above prefixes.

The valid prefixes for qcom-6.18.y are:

Prefix Meaning
FROMLIST: Patch posted to mailing list (lore.kernel.org)
FROMGIT: Patch taken from a maintainer git tree
UPSTREAM: Patch merged into Linus's mainline tree
BACKPORT: Upstream patch backported with modifications
QCLINUX: Vendor-only change with no upstream equivalent
PENDING: ❌ Not valid for qcom-6.18.y
WORKAROUND: Temporary fix not suitable for upstream

Fix:

Choose the appropriate prefix based on the patch's upstream status:

If posted to lore.kernel.org but not yet merged:

git rebase -i f46367083aeae92dacbf35b714faf4c66cc9b7dd
# mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay

[original body]

Link: https://lore.kernel.org/...
Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>"
git rebase --continue

If vendor-only (not posted upstream):

git rebase -i f46367083aeae92dacbf35b714faf4c66cc9b7dd
# mark commit as 'edit'
git commit --amend -m "QCLINUX: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay

[original body]

Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>"
git rebase --continue

Reproduce locally:

git log f46367083aeae92dacbf35b714faf4c66cc9b7dd..82bc62baa85838c8aeb5e0d0562957a3559007b7 \
  --format="%H %s" | while read sha subject; do
  if ! echo "$subject" | grep -qE '^(FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|WORKAROUND):'; then
    echo "MISSING valid prefix: $sha $subject"
  fi
done

Verdict

2 blockers must be fixed before merge:

  1. check-patch-compliance failure — Replace PENDING: with FROMLIST: (if posted upstream) or QCLINUX: (if vendor-only) and add a Link: tag if applicable.

  2. tag-check failure — The qcom-6.18.y branch requires a valid prefix tag. PENDING: is not accepted for this branch. Use FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, or WORKAROUND: based on the patch's upstream status.

Recommended action: Determine whether this patch has been (or will be) posted upstream:

  • If yes → use FROMLIST: prefix + add Link: tag
  • If no → use QCLINUX: prefix (vendor-only)

All other checkers passed or were correctly skipped.

@manikanta-qli

Copy link
Copy Markdown

Please split the DT, keeping only the Ethernet in the staging file. Submit the rest of the changes upstream

Done

@manikanta-qli
manikanta-qli force-pushed the mmanikan/hamoa-qps615-6.18 branch from 82bc62b to 6600c69 Compare October 23, 2026 11:54
@qlijarvis

Copy link
Copy Markdown

PR #1313 — validate-patch

PR: #1313

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Upstream commit: N/A (vendor-only PENDING: commit)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A No upstream source; PENDING: prefix indicates work-in-progress
Body preserves rationale ✅ Clear description of QPS615 PCIe switch topology and Ethernet overlay
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved ✅ Original author in From: field
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds hamoa-evk-staging.dtbo build target
arch/arm64/boot/dts/qcom/hamoa-evk-staging.dtso ✅ New overlay describing QPS615 PCIe switch with dual TC956X Ethernet

Issues

  • ⚠️ Integration presence: Commit is missing from both qcom-next and kernel-topics branches (per integration_presence_report.md). For a PENDING: commit, this may be expected if it's truly work-in-progress, but it should be tracked for eventual integration.

Verdict

This is a vendor-only PENDING: commit with no upstream lore link by design. The commit message is clear, the diff adds a new device tree overlay for QPS615 Ethernet hardware, and basic hygiene checks pass. However, the commit is not yet present in qcom-next or topics branches. If this is intended as work-in-progress staging content, the PENDING: prefix is appropriate. If it's ready for integration, it should be merged to the appropriate topic branch first.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: No — 1/1 commit missing from both qcom-next and topics (per integration_presence_report.md). For PENDING: commits, absence from integration branches may be expected during development.

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1313 — checker-log-analyzer

PR: #1313
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/39949646610

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Warnings are pre-existing tree issues
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ❌ PENDING: not valid for qcom-6.18.y branch

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/39949646610

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Warnings are pre-existing tree issues
sparse-check ⏭️ No C/H changes
check-uapi-headers ⏭️ No C/H changes
check-patch-compliance ❌ PENDING: prefix not in allowed list
tag-check ❌ PENDING: not valid for qcom-6.18.y branch

❌ check-patch-compliance

Root cause: Commit uses PENDING: prefix, which is not in the checker's allowed list (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Commit summary does not start with a required prefix

Fix: Change the prefix based on the patch origin:

If the patch is... Use this prefix
Posted to lore.kernel.org FROMLIST: + add Link: trailer
In a maintainer git tree FROMGIT: + add Link: to tree
Merged into Linus's tree UPSTREAM: + add Link: to lore
Vendor-only, no upstream QCLINUX: (but see note below)

Note: PENDING: and QCLINUX: are vendor-internal prefixes that always fail check-patch-compliance. This is a known checker limitation — the checker enforces only upstream-linkable prefixes.

Reproduce locally:

cd /path/to/kernel
../kernel-checkers/check-patch-compliance.sh <base_sha> <head_sha>

Recommended action:

git rebase -i <base_sha>   # mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay"
# Add Link: trailer to commit body if posted upstream
git rebase --continue

❌ tag-check

Root cause: PR targets branch qcom-6.18.y, which requires all commits to start with a valid prefix. PENDING: is not a recognized prefix for this branch.

Failure details:

Commit 6600c692d4e0 ("PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay")
Target branch: qcom-6.18.y (not qcom-next or qcom-next-staging)
Subject prefix: PENDING:

Fix: All branches except qcom-next and qcom-next-staging require one of these prefixes:

Prefix Meaning
FROMLIST: Posted to mailing list (lore.kernel.org)
FROMGIT: Taken from a maintainer git tree
UPSTREAM: Merged into Linus's mainline tree
BACKPORT: Upstream patch backported with modifications
QCLINUX: Vendor-only change with no upstream equivalent
WORKAROUND: Temporary fix not suitable for upstream

Reproduce locally:

git log <base>..<head> --format="%H %s" | grep -v -E '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT|QCLINUX|PENDING|WORKAROUND):'

Recommended action:

git rebase -i <base_sha>   # mark commit as 'edit'
# Choose the appropriate prefix based on patch origin:
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay"
# or
git commit --amend -m "QCLINUX: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay"
git rebase --continue

Verdict

2 blockers must be fixed before merge:

  1. Change subject prefix from PENDING: to a valid prefix (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, or WORKAROUND:)
  2. Add Link: trailer if using FROMLIST:, FROMGIT:, UPSTREAM:, or BACKPORT: prefix

Note: If this is a vendor-only patch with no upstream equivalent, use QCLINUX: prefix. However, be aware that QCLINUX: will still fail check-patch-compliance (known checker limitation), but it will pass tag-check for the qcom-6.18.y branch.

All other checkers passed or were correctly skipped. The dtb-check warnings shown in the log are pre-existing tree issues (monaco camera overlay, lemans camera sensor, x1-staging TGU nodes, glymur-staging) and are not introduced by this PR.

@manikanta-qli
manikanta-qli force-pushed the mmanikan/hamoa-qps615-6.18 branch from 6600c69 to 5759b7c Compare October 24, 2026 15:46
Add the hamoa-evk staging overlay for the QPS615 M.2 E-key
daughter card.

With QPS615 installed, the M.2 E-key slot is occupied by the QPS615
PCIe switch (pci1179,0623) instead of a WLAN chip.

Describe the QPS615 PCIe switch topology and the dual TC956X
Ethernet functions connected through the downstream port. Add
GPIO-based PHY reset handling and disable L0s/L1 ASPM for the
QPS615 PCIe path.

Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>
@manikanta-qli
manikanta-qli force-pushed the mmanikan/hamoa-qps615-6.18 branch from 5759b7c to 31d089d Compare October 24, 2026 16:03
@qlijarvis

Copy link
Copy Markdown

PR #1313 — validate-patch

PR: #1313

Verdict Issues Detailed Report
⚠️ 0 Full report

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Upstream commit: N/A (PENDING: prefix — not yet posted upstream)
Verdict: ⚠️ N/A — Validation not applicable for PENDING commits

Commit Message

Check Status Note
Subject matches upstream N/A PENDING: prefix — no upstream source to compare
Body preserves rationale ✅ Clear description of QPS615 M.2 E-key daughter card functionality
Fixes tag present/correct N/A New feature, not a fix
Authorship preserved N/A Original work by commit author
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds hamoa-evk-staging.dtbo build target
arch/arm64/boot/dts/qcom/hamoa-evk-staging.dtso ✅ New overlay for QPS615 PCIe switch and dual TC956X Ethernet

Issues

None — commit message and diff structure are appropriate for a PENDING staging overlay.

Verdict

This is a PENDING commit (work-in-progress, not yet posted upstream). Validation against lore.kernel.org is not applicable. The commit message clearly describes the hardware configuration and the diff adds a staging device tree overlay following the established pattern in this tree.

Final Summary

  1. Lore link present: No — PENDING: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — work-in-progress, not posted upstream
  4. PR present in qcom-next/topics: No — integration_presence_report.md shows 1/1 commit missing from both qcom-next and topics (expected for new PENDING work)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: c7896917e523946138ce654d4b6c1e33d5a8f4e5
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1313 — checker-log-analyzer

PR: #1313
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/40109934769

Checker Result Summary
Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Invalid prefix: PENDING:
tag-check ❌ Missing required prefix

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1313 - PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/40109934769
Target branch: qcom-6.18.y

Checker Result Summary
checkpatch ✅ No style issues
dt-binding-check ⏭️ Skipped (no binding changes)
dtb-check ✅ No DTB validation errors
sparse-check ⏭️ Skipped (no C/H changes)
check-uapi-headers ⏭️ Skipped (no UAPI changes)
check-patch-compliance ❌ Invalid prefix: PENDING:
tag-check ❌ Missing required prefix

❌ check-patch-compliance

Root cause: Commit uses PENDING: prefix, which is not in the allowed list for check-patch-compliance.

Failure details:

Checking commit: PENDING: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay
Commit summary does not start with a required prefix

Analysis:

The check-patch-compliance checker only accepts these prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (from maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The commit uses PENDING:, which is a vendor-internal prefix for work-in-progress patches not yet posted upstream. This is a known limitation of the checker — it enforces upstream-linkable prefixes only.

Fix:

If this patch has been posted to a mailing list (lore.kernel.org):

git rebase -i 113239da311aa1301351cda3a2f4c941bf5118d5
# mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay"
# Add Link: <lore-url> to the commit body
git rebase --continue

If this patch has not been posted upstream:

  • The checker will always fail for PENDING: commits
  • This is expected behavior for vendor-only work-in-progress patches
  • Consider posting to the devicetree mailing list if appropriate

Reproduce locally:

cd <kernel-tree>
git log 113239da311aa1301351cda3a2f4c941bf5118d5..31d089d481657f12e40891fb52fef7344ebe38c1 --format="%s"

❌ tag-check

Root cause: Target branch qcom-6.18.y requires all commits to have a valid subject prefix; PENDING: is not accepted by check-patch-compliance.

Failure details:

The PR targets qcom-6.18.y, which is not qcom-next or qcom-next-staging. All branches except those two require every commit subject to start with one of:

  • FROMLIST: / FROMGIT: / UPSTREAM: / BACKPORT: / QCLINUX: / PENDING: / WORKAROUND:

While PENDING: is technically a valid prefix for the tag-check, it fails check-patch-compliance because that checker only accepts upstream-linkable prefixes (FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:).

Fix:

Choose the appropriate prefix based on the patch status:

Situation Correct prefix
Posted to lore.kernel.org, not yet merged FROMLIST: + add Link: trailer
In a maintainer git tree FROMGIT: + add Link: trailer
Merged into Linus's tree UPSTREAM: + add Link: trailer
Backported with modifications BACKPORT: + add Link: trailer
Vendor-only, no upstream QCLINUX: (but will still fail check-patch-compliance)

Recommended action:

git rebase -i 113239da311aa1301351cda3a2f4c941bf5118d5
# mark commit as 'edit'
git commit --amend -m "FROMLIST: arm64: dts: qcom: hamoa-evk: add QPS615 Ethernet overlay

Add the hamoa-evk staging overlay for the QPS615 M.2 E-key
daughter card.

[rest of commit message]

Link: <lore-url-if-posted>
Signed-off-by: Manikanta Mylavarapu <mmanikan@qti.qualcomm.com>"
git rebase --continue

Reproduce locally:

git log 113239da311aa1301351cda3a2f4c941bf5118d5..31d089d481657f12e40891fb52fef7344ebe38c1 --format="%H %s" | \
  grep -vE '^[a-f0-9]+ (FROMLIST|FROMGIT|UPSTREAM|BACKPORT):'

Verdict

1 blocker must be fixed before merge:

The commit subject uses PENDING: prefix, which fails check-patch-compliance for the target branch qcom-6.18.y.

Action required:

  1. If the patch has been posted to lore.kernel.org → change prefix to FROMLIST: and add Link: trailer
  2. If the patch has not been posted → either:
    • Post it upstream first, then use FROMLIST: + Link:
    • Use QCLINUX: if it's vendor-only (but note this will still fail the checker)
    • Keep PENDING: and accept that the checker will fail (not recommended for merge)

All other checkers passed or were correctly skipped. The patch itself has no style, binding, DTB validation, sparse, or UAPI issues.

@qcomlnxci

Copy link
Copy Markdown

Test Matrix

Test Case kbdev-hamoa-iot-evk-multimedia kbdev-lemans-evk-multimedia kbdev-monaco-evk-multimedia kbdev-purwa-iot-evk-multimedia kbdev-qcs615-ride-multimedia kbdev-qcs6490-rb3gen2-multimedia kbdev-qcs8300-ride-multimedia kbdev-qcs9100-ride-r3-multimedia kbdev-shikra-iqs-evk-multimedia
Audio_Card_Registration ✅ Pass ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip
BT_FW_KMD_Service ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_ON_OFF ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
BT_SCAN ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPUFreq_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
CPU_affinity ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
DSP_AudioPD ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
Ethernet_Basic_Validation ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ❌ Fail ❌ Fail ⚠️ skip
Freq_Scaling ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
GIC ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
IPA ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
Interrupts ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
KVM_Driver ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
KVM_EL2_DTB ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
KVM_Infra ❌ Fail ✅ Pass ✅ Pass ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail
OpenCV ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
PCIe ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ❌ Fail
Probe_Failure_Check ❌ Fail ✅ Pass ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail ❌ Fail
RMNET ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
UFS_Validation ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
USBHost ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip ❌ Fail ✅ Pass ❌ Fail
WiFi_Firmware_Driver ✅ Pass ✅ Pass ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
WiFi_OnOff ✅ Pass ⚠️ skip ❌ Fail ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
adsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ⚠️ skip
cdsp_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
gpdsp_remoteproc ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip ⚠️ skip ⚠️ skip ✅ Pass ✅ Pass ⚠️ skip
hotplug ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
irq ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
kaslr ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
pinctrl ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
qcom_hwrng ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ◻️
rngtest ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
shmbridge ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
smmu ❌ Fail ❌ Fail ✅ Pass ❌ Fail ❌ Fail ✅ Pass ✅ Pass ❌ Fail ✅ Pass
watchdog ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass
wpss_remoteproc ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass ✅ Pass

@sgaud-quic

Copy link
Copy Markdown
Contributor

Mainline PR is still pending to merge : qualcomm-linux/kernel-topics#2070
Will wait for this to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants