Repository navigation
[ET][native] Bundle sample method calls in .ptn packages - #24230
Merged
Merged
Conversation
Pull Request resolved: #24171 A `.ptn` can carry recorded method calls under `samples/<set>/` as `index.json` plus `data.safetensors`; program loaders ignore them. A sample is an ordered list of calls from the initial state with no reset between, each naming the method it runs, so stateful sequences such as LLM prefill then teacher-forced decode can be checked whether they use one method or several. Tolerance resolves per call, then sample, then set, and `write_samples` warns above 1e-3. `write_samples` and `read_samples` live in `exir/_serialize/_ptn_samples.py`. The spec is in `backends/native/README.md`; review it first. Authored with Claude Code. ghstack-source-id: 458609819 @exported-using-ghexport Differential Revision: [D125544384](https://our.internmc.facebook.com/intern/diff/D125544384/)
pytorchbot
requested review from
JacobSzwejbka and
larryliu0820
as code owners
October 28, 2026 12:59
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24230
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Pending, 3 Unrelated FailuresAs of commit 955bb9b with merge base 4db778e ( NEW FAILURE - The following job has failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
JakeStevens
approved these changes
Oct 28, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #24171 by @digantdesai
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/digantdesai/177/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/177/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/177/orig
Differential Revision: D125544384
@diff-train-skip-merge