Repository navigation
Fix codecs.register_error callback type - #16518
Merged
AlexWaygood merged 1 commit intoOct 13, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Oct 13, 2026
The callback receives one of the three concrete Unicode codec error types. Model that union so contextual typing exposes their shared attributes.
stroxler
force-pushed
the
fix-codecs-register-error-handler-type
branch
from
October 13, 2026 16:40
094b25f to
a531872
Compare
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: scipy-stubs (https://github.com/scipy/scipy-stubs)
- tests/misc/test_submodules_empty.pyi:3: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback receives one of the three concrete Unicode codec error types, not just
UnicodeErrorModel that union so contextual typing exposes their shared attributes. I found this because an engineer using Pyrefly ran into a bug where Pyrefly reported attribute errors on the use of
e.start/e.end/e.objectas in