Repository navigation
Fix #3149 docs template link + downloads URL reversing bugs - #3187
Closed
alvynabranches wants to merge 2 commits into
Closed
alvynabranches wants to merge 2 commits into
alvynabranches wants to merge 2 commits into
Conversation
The CPython repo uses documentation.yml, not documentation.md. The old link opened a blank issue template. Updated in BUG, DOCS, and REQUEST issue templates.
OS.get_absolute_url used os_slug kwarg but route expects slug, causing NoReverseMatch on every call. Fallback redirects in DownloadLatestPython2 and DownloadLatestPyManager used bare names (download/downloads) that do not exist, causing 500 when no latest release is flagged. Standardize fallbacks and feed link on download:download namespace. Added regression tests for OS URL and fallback redirects.
Member
|
this does too much, should be scoped PRs please :) |
Author
|
Follow-up audit note (no code changes in this comment): I swept every literal
So beyond the two commits in this PR, the audit found no further verified crash-level bugs. Remaining open items (#2677 content, #2847 infra, #3185 process, #3176 covered by #3177) are documented in the PR description as needing non-code handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single PR with per-issue commits from a full audit (Docker test suite + static review).
Commit 1 — Closes #3149: Incorrect link to new documentation issue
CPython's issue template is
documentation.yml, notdocumentation.md.The old link in this repo opened a blank template. Updated in:
.github/ISSUE_TEMPLATE/BUG.yml.github/ISSUE_TEMPLATE/DOCS.yml.github/ISSUE_TEMPLATE/REQUEST.ymlVerified: https://github.com/python/cpython/tree/main/.github/ISSUE_TEMPLATE contains
documentation.yml(no.md).Commit 2 — Downloads URL reversing bugs (found via audit)
OS.get_absolute_urlused kwargos_slug, but routedownload_os_listexpectsslug(apps/downloads/urls.py:19). Every call raisedNoReverseMatch. Fixed inapps/downloads/models.py:58, verified: now returns/downloads/windows/.DownloadLatestPython2.get_redirect_urlfallback used barereverse("download")(no such name) — 500 when no Python 2 flagged latest. Fixed todownload:download.DownloadLatestPyManager.get_redirect_urlfallback used barereverse("downloads")— same 500. Fixed todownload:download.DownloadLatestPython3,DownloadLatestPrerelease, andReleaseFeed.linkfallbacks ondownload:download(bothdownload:anddownloads:resolve today, butdownload:matches the instance namespace used everywhere else).Added regression tests:
test_os_get_absolute_urltest_latest_python2_redirects_to_downloads_when_no_latesttest_latest_pymanager_redirects_to_downloads_when_no_latestIssues reviewed with no code change
/psf/records/board/resolutions/is a hand-maintained CMS page (no model/view/URL;minutesapp stores a single MarkupField body). Needs CMS edit by staff, not a code PR. Anchor support from anchors for resolutions #3175 already merged.mail.python.orgHyperKitty export infra outside this repo; only nginx redirects to it live here. Needs infra-side timeout/sizing work.chore/issue-3176-remove-ethicalads). Did not duplicate; that PR still needs a rebase onto main's EA CSP fixes (fix CSP #3183/More CSP fixes for EA #3184).Verification (per README contributing guide)
makemigrations --check --dry-run: No changes detectedruff check: All checks passed;ruff format --check: 655 files formattedcoverage run manage.py test): 1072 tests, OK (211s)