Repository navigation
[mypyc] Fix reference leaks on vecs module initialization failure - #22246
Merged
p-sawicki merged 2 commits intoOct 21, 2026
Merged
Conversation
JukkaL
approved these changes
Oct 21, 2026
| assert v == vec[u8]([1, 2, 1, 2, 3]) | ||
| assert new == vec[u8]([1, 2, 3]) | ||
|
|
||
| [case testLibrtVecsFailedImportOwnership_librt] |
Collaborator
There was a problem hiding this comment.
This is testing such a niche use case that I don't think it's worth it have an expensive run test for it. I think you can just remove the test -- the test has already served its purpose and shown that the fix works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add decrefs for temporaries that would leak on initialization failure.
Remove decref of
VecTypeafter it's been successfully added to the module because that steals it.