fix: ClassVar[Final[...]] collapses to Any instead of inner type (#21906) - #22012
Open
chenzeyan54-commits wants to merge 1 commit into
Open
chenzeyan54-commits wants to merge 1 commit into
chenzeyan54-commits wants to merge 1 commit into
Conversation
…hon#21906) Nested Final inside ClassVar on Python 3.13+ accepts the annotation (no valid-type error) but the variable's type still collapsed to AnyType(from_error), silently losing type information. In try_analyze_special_unbound_type's FINAL_TYPE_NAMES branch, when self.allow_final is True (i.e. the nested Final is legitimately accepted in this context), preserve and return the inner type instead of falling through to AnyType(from_error). Regression guard: testFinalUsedWithClassVarAfterPy313PreservesType.
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #21906
On Python 3.13+,
ClassVar[Final[...]]accepts the annotation (novalid-typeerror), but the variable's type still silently collapses to
AnyType(from_error), losing all type information.Root Cause
In
try_analyze_special_unbound_type'sFINAL_TYPE_NAMESbranch, whenself.allow_finalisTrue(i.e. the nestedFinalis legitimatelyaccepted, e.g. inside
ClassVar[Final[...]]on 3.13+), the code fellthrough to
return AnyType(TypeOfAny.from_error)instead of analyzing theinner type.
Fix
In the same branch, when
self.allow_finalisTrueand theFinalhastype arguments, preserve and return the inner type by recursing into
anal_type(t.args[0]):Verification
testFinalUsedWithClassVarAfterPy313PreservesTypeintest-data/unit/check-final.test—reveal_type(A.cv)reportsbuiltins.dict[type[B], __main__.Ainstead ofAny.testFinalUsedWithClassVarAfterPy313(no error) andtestFinalUsedWithClassVar(3.12 still errors) are unaffected.