Skip to content

gh-159210: Disable PIP_REQUIRE_VIRTUALENV when updating certificates. - #159214

Merged
freakboy3742 merged 2 commits into
python:mainfrom
freakboy3742:macos-cert-install
Oct 12, 2026
Merged

gh-159210: Disable PIP_REQUIRE_VIRTUALENV when updating certificates.#159214
freakboy3742 merged 2 commits into
python:mainfrom
freakboy3742:macos-cert-install

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Oct 12, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

If the user has set PIP_REQUIRE_VIRTUALENV in their .zprofile or similar, the Install Certificates script included with the macOS installer will fail.

Since the point of this script is to install into the global environment, it's safe to unset that variable before invoking the pip install.

@freakboy3742
freakboy3742 requested a review from a team as a code owner October 12, 2026 03:38
@freakboy3742 freakboy3742 added skip news 3.14 bugs and security fixes 3.15 bugs and security fixes labels Oct 12, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Oct 12, 2026
Closed
ned-deily
ned-deily reviewed Oct 12, 2026
View reviewed changes
Comment thread Mac/BuildScript/resources/install_certificates.command
@freakboy3742
freakboy3742 merged commit 03df941 into python:main Oct 12, 2026
34 checks passed
@freakboy3742
freakboy3742 deleted the macos-cert-install branch October 12, 2026 05:47
@freakboy3742 freakboy3742 added awaiting merge needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes and removed 3.14 bugs and security fixes 3.15 bugs and security fixes labels Oct 12, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 12, 2026

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 12, 2026

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Oct 12, 2026

Copy link
Copy Markdown

GH-159218 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 12, 2026
@bedevere-app

bedevere-app Bot commented Oct 12, 2026

Copy link
Copy Markdown

GH-159219 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2026
freakboy3742 added a commit that referenced this pull request Oct 12, 2026
@miss-islington @freakboy3742
[3.14] gh-159210: Disable virtualenv enforcement when updating certif…
d7606be 
…icates. (GH-159214) (#159219)

Ensures that the macOS Install Certificates script can run when the user has
PIP_REQUIRE_VIRTUALENV or PIP_REQUIRE_VENV set in their shell.
(cherry picked from commit 03df941)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 added a commit that referenced this pull request Oct 12, 2026
@miss-islington @freakboy3742
[3.15] gh-159210: Disable virtualenv enforcement when updating certif…
719c257 
…icates. (GH-159214) (#159218)

Ensures that the macOS Install Certificates script can run when the user has
PIP_REQUIRE_VIRTUALENV or PIP_REQUIRE_VENV set in their shell.
(cherry picked from commit 03df941)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@freakboy3742 @ned-deily