Conversation
--with-address-sanitizer and --with-memory-sanitizer unconditionally disabled pymalloc, even when --with-pymalloc was given explicitly. Only apply the default when the user did not specify a preference.
vasiliyk
requested review from
AA-Turner,
corona10,
emmatyping,
erlend-aasland and
itamaro
as code owners
September 21, 2026 23:32
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
Please also update the --with-address-sanitizer documentation, the note about --without-pymalloc is redundant.
StanFromIreland
added a commit
to StanFromIreland/cpython
that referenced
this pull request
Sep 22, 2026
Documentation build overview
6 files changed ·
|
StanFromIreland
changed the title
--with-pymalloc override the sanitizer default
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
Just a few more docs tweaks, we also need to update the note in the Memory Management documentation:
Lines 708 to 710 in b0dda15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--with-address-sanitizerand--with-memory-sanitizerconfigure options unconditionally setwith_pymalloc=no, so an explicit--with-pymallocwas silently ignored.Only apply that default when
--with-pymallocor--without-pymallocwas not given.Tested with the regenerated configure:
--with-address-sanitizer --with-pymallocnow definesWITH_PYMALLOC, and--with-address-sanitizeralone still leaves it undefined.