Repository navigation
IDLE: search regex errors should be in/attached to search dialog #69365
Description
| BPO | 25178 |
|---|---|
| Nosy | @terryjreedy, @roseman |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/terryjreedy'
closed_at = None
created_at = <Date 2015-09-19.18:34:41.281>
labels = ['expert-IDLE', 'type-bug', '3.9']
title = 'IDLE: search regex errors should be in/attached to search dialog'
updated_at = <Date 2020-01-07.22:19:44.085>
user = 'https://github.com/roseman'bugs.python.org fields:
activity = <Date 2020-01-07.22:19:44.085>
actor = 'terry.reedy'
assignee = 'terry.reedy'
closed = False
closed_date = None
closer = None
components = ['IDLE']
creation = <Date 2015-09-19.18:34:41.281>
creator = 'markroseman'
dependencies = []
files = []
hgrepos = []
issue_num = 25178
keywords = []
message_count = 2.0
messages = ['251097', '359554']
nosy_count = 2.0
nosy_names = ['terry.reedy', 'markroseman']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'test needed'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue25178'
versions = ['Python 3.9']Linked PRs
- gh-69365: Show search pattern errors in the IDLE search dialogs #157598
- [3.15] gh-69365: Show search pattern errors in the IDLE search dialogs (GH-157598) #157667
- [3.14] gh-69365: Show search pattern errors in the IDLE search dialogs (GH-157598) #157668
- [3.13] gh-69365: Show search pattern errors in the IDLE search dialogs (GH-157598) #157669
- gh-69365: Fix reference leak in IDLE search dialogs #157754
- [3.14] gh-69365: Fix reference leak in IDLE search dialogs (GH-157754) #157764
- [3.13] gh-69365: Fix reference leak in IDLE search dialogs (GH-157754) #157765
Metadata
Metadata
Assignees
Projects
- Status
Activity
roseman commentedon Sep 19, 2015
Follow-on to bpo-25173, any regex errors are displayed by SearchEngine but they should be shown by the dialog where the user is typing the error. Either as a modal tkMessageBox attached to the dialog, or as an inline error in the dialog itself.
terryjreedy commentedon Jan 7, 2020
I like the way that Open Module puts error messages in red under the entry box and allows users to correct without first clicking a modal message away. I would like to do the same here.
serhiy-storchaka commentedon Sep 15, 2026
#157598 shows the error in red below the entry, as the Open Module dialog does, and moves the cursor to the offending character. It also fixes the "Whole word" option with a regular expression:
a|bwas anchored only on the outer sides, and a pattern ending with a backslash matched\binstead of being an error.gh-69365: Show search pattern errors in the IDLE search dialogs (GH-1…
[3.13] gh-69365: Show search pattern errors in the IDLE search dialogs (
[3.14] gh-69365: Show search pattern errors in the IDLE search dialogs (
encukou commentedon Sep 18, 2026
Looks like this introduced a refleak: https://buildbot.python.org/#/builders/2263/builds/275
serhiy-storchaka commentedon Sep 18, 2026
Thank you, @encukou. The leak is the variable trace that clears the error label — it was never removed, so it kept the whole dialog alive. #157754 fixes this.
gh-69365: Fix reference leak in IDLE search dialogs (GH-157754)
pythongh-69365: Fix reference leak in IDLE search dialogs (pythonGH-1…
terryjreedy commentedon Sep 18, 2026
For 3.15, refleak fix merged into the original on-hold backport.
[3.13] gh-69365: Fix reference leak in IDLE search dialogs (GH-157754) (
[3.14] gh-69365: Fix reference leak in IDLE search dialogs (GH-157754) (
[3.15] gh-69365: Show search pattern errors in the IDLE search dialogs (