Skip to content

feat(list-overrides): surface source config in details output - #1413

Merged
rd4398 merged 1 commit into
python-wheel-build:new-resolver-configfrom
rd4398:list-overrides
Oct 30, 2026
Merged

rd4398 merged 1 commit into
python-wheel-build:new-resolver-configfrom
rd4398:list-overrides

Conversation

@rd4398

@rd4398 rd4398 commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Add a 'source' column/field to the list-overrides details table, CSV, and JSON exporters showing the source resolver provider name (blank for legacy packages). Also read min_release_age from the source resolver config when present, falling back to the legacy resolver_dist setting.

closes #1402

@rd4398
rd4398 requested a review from a team as a code owner October 30, 2026 14:40
@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Oct 30, 2026

@LalatenduMohanty LalatenduMohanty left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! #1402 now also covers package list-versions (merged from #1411). Could you include it in this PR?

@LalatenduMohanty

Copy link
Copy Markdown
Member

Two small things for packages that use source: in variants:

  1. source and min_release_age change with --variant. Example: the package uses pypi-sdist, and its cpu variant uses pypi-prebuilt. --variant cpu shows pypi-prebuilt, but --variant rocm shows pypi-sdist. Could source show the package-level setting, so the output is the same for every variant?
  2. Variant columns ignore variant source:. They only check the old pre_built flag, so a variant with pypi-prebuilt shows yes instead of pre-built. Could they also check the variant's source:?

A test with a variant-level source: would cover both.

Comment thread src/fromager/commands/list_overrides.py Resolved
@mergify

mergify Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Comment thread src/fromager/commands/package.py Resolved
Add a 'source' column/field to the list-overrides details table, CSV,
and JSON exporters showing the package-level source resolver provider
(blank for legacy packages) so the column does not change with
--variant. Variant columns now also mark variants whose 'source:'
resolver returns prebuilt wheels as 'pre-built'.

package list-versions now builds its provider through
sources.get_source_provider() so 'source:' packages list versions from
their configured provider instead of the legacy hook path, and its
cooldown status reads the per-package min_release_age through the
shared PackageBuildInfo.resolver_min_release_age helper, which now
prefers the source resolver's value over resolver_dist. An explicit
--distribution-type is rejected for 'source:' packages instead of
being silently ignored, since resolution follows the source config.

Co-Authored-By: Claude Code <noreply@anthropic.com>
Signed-off-by: Rohan Devasthale <rdevasth@redhat.com>
@rd4398
rd4398 merged commit ccd98cc into python-wheel-build:new-resolver-config Oct 30, 2026
71 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants