Await asynchronous sinks when flushing collected values - #500
Merged
martindurant merged 1 commit intoSep 22, 2026
Merged
Conversation
Member
|
@saitakarcesme , are you an active user of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect.flush()currently drops the awaitables returned by downstream sinks. A synchronous caller can return before the sink runs, andawait collector.flush()raises aTypeError.Use
emit()and return its result so flushing follows the stream's existing synchronous/asynchronous execution mode. Clear the captured batch before invoking downstream callbacks, since those callbacks can collect more values whileemit()waits; release the captured metadata references infinally.Fixes #468.
Validation:
emit()).pythonwas not on PATH. Both pass when rerun with the virtualenv bin directory on PATH.git diff --checkpasses.AI disclosure: This contribution was prepared and tested by OpenAI Codex under the account owner's authorization.