Repository navigation
Keep wildcard keys when a mapped value is null or empty - #653
Open
Cherith1222 wants to merge 1 commit into
Open
Cherith1222 wants to merge 1 commit into
Cherith1222 wants to merge 1 commit into
Conversation
A wildcard stopped scanning when a mapped value was null, or when a list value was empty, so later keys were dropped. Remember whether another key remains instead of treating those values as the end. Fixes python-restx#409 Fixes python-restx#283 AI-assisted (Cursor)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Wildcard marshalling treated a null value, or an empty list, as the end of the mapping. Keys that had not been visited yet were dropped.
List.format(None)is[], so an empty list compared equal to the old end sentinel. The scan now ends only when no further key remains. A null value is still included unlessskip_noneis set, and an empty list is kept.Fixes #409
Fixes #283
Cherith reviewed this diff and confirmed it with the person who helped draft it.
Drafted with Cursor. Model: Grok 4.7.
Types of changes
Checklist
Further comments
Windows, Python 3.13.
pytest tests --benchmark-skip(the same skipinv testuses): 1233 passed, 6 skipped.tzdatawas installed sozoneinfocan resolveCETon Windows. Benchmarks were not run.toxwas not run; this machine does not have the other Python versions in the matrix.