Repository navigation
Choose currency long-name plurals from the rounded number - #1415
Open
ryanduguid wants to merge 1 commit into
Open
ryanduguid wants to merge 1 commit into
ryanduguid wants to merge 1 commit into
Conversation
format_currency(..., format_type='name') looked up the plural form of the currency name from the number before rounding, so 0.6 ISK was displayed as "1 Icelandic krónur" and 0.5 JPY in Russian as "0 японской иены". When rounding changes the number, look up the plural form from the number as it is displayed. Numbers that rounding does not change, and significant-digit, scientific and percent or per-mille patterns, keep their current plural form.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_currency(..., format_type='name')chose the plural form of the currency name from the number before rounding, so 0.6 ISK printed as "1 Icelandic krónur" and 0.5 JPY in Russian as "0 японской иены".When rounding changes the number, the plural form now comes from the number as displayed. Everything else keeps its current plural form: numbers that rounding does not change (so
Decimal('1.00')USD stays "1.00 US dollars"),decimal_quantization=False, and significant-digit, scientific and percent or per-mille patterns, which round differently.Adds a regression test, which fails without the fix.