Skip to content

Decode JavaScript vertical-tab escapes during message extraction #1409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akx merged 2 commits into from
Oct 30, 2026
Merged

Decode JavaScript vertical-tab escapes during message extraction #1409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10830a4
Fix JavaScript vertical-tab escape decoding
Dcastroro Oct 27, 2026
4de1dd2
Simplify tests
akx Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel/messages/jslexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'[', ']', '{', '}', '!', '--', '++', '~', ',', ';', '.', ':',
], key=len, reverse=True) # fmt: skip

escapes: dict[str, str] = {'b': '\b', 'f': '\f', 'n': '\n', 'r': '\r', 't': '\t'}
escapes: dict[str, str] = {'b': '\b', 'f': '\f', 'n': '\n', 'r': '\r', 't': '\t', 'v': '\v'}

name_re = re.compile(r'[\w$_][\w\d$_]*', re.UNICODE)
dotted_name_re = re.compile(r'[\w$_][\w\d$_.]*[\w\d$_.]', re.UNICODE)
Expand Down
4 changes: 3 additions & 1 deletion tests/messages/test_js_extract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@ def test_simple_extract():
msg1 = _('simple')
msg2 = gettext('simple')
msg3 = ngettext('s', 'p', 42)
msg4 = gettext('before\\vafter')
""")
messages = \
list(extract.extract('javascript', buf, extract.DEFAULT_KEYWORDS,
[], {}))

assert messages == [(1, 'simple', [], None),
(2, 'simple', [], None),
(3, ('s', 'p'), [], None)]
(3, ('s', 'p'), [], None),
(4, 'before\vafter', [], None)]


def test_various_calls():
Expand Down
2 changes: 2 additions & 0 deletions tests/messages/test_jslexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ def test_unquote():
assert jslexer.unquote_string(r'"h\u00ebllo"') == "hëllo"
assert jslexer.unquote_string(r'"h\xebllo"') == "hëllo"
assert jslexer.unquote_string(r'"\xebb"') == "ëb"
assert jslexer.unquote_string(r'"a\vb"') == "a\vb"
assert jslexer.unquote_string(r'"\\v"') == r"\v"


def test_dollar_in_identifier():
Expand Down
Loading