Repository navigation
Resolve deprecated short unit identifiers through their replacements - #1408
Merged
akx merged 2 commits intoOct 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1408 +/- ##
==========================================
+ Coverage 93.55% 93.56% +0.01%
==========================================
Files 27 27
Lines 4931 4940 +9
==========================================
+ Hits 4613 4622 +9
Misses 318 318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akx
force-pushed
the
fix/deprecated-short-unit-aliases-20261027
branch
from
October 30, 2026 11:18
00ae4f1 to
12392bb
Compare
akx
approved these changes
Oct 30, 2026
akx
left a comment
akx
left a comment
Member
There was a problem hiding this comment.
Nice, thank you. I simplified the test a bit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deprecated short unit identifiers
permillion,portion, andportion-per-1e9emit a deprecation warning but then fail lookup. The exact-name lookup uses the replacement ID, while the suffix lookup still uses the deprecated name.Continue suffix matching with the replacement ID. Tests cover all six deprecated IDs through both
format_unitandget_unit_name, check that each lookup emits exactly one warning, and compare results with the replacement IDs.Validation: 30 unit tests passed; 40 tests passed when including the unit-module doctests. Ruff lint/format and
git diff --checkpass. The three short-alias cases fail against the original source.