Minor bug in JavaScript lexer; failing to recognize numbers

There is a regex mistake:

Line 25 in 7ebdf5a

name_re = re.compile(r'[\w$_][\w\d$_]*', re.UNICODE)

Here is how it is applied:

Lines 41 to 47 in 7ebdf5a

    
               ('name', name_re), 
        
               ('number', re.compile(r'''( 
        
                   (?:0|[1-9]\d*) 
        
                   (\.\d+)? 
        
                   ([eE][-+]?\d+)? | 
        
                   (0x[a-fA-F0-9]+) 
        
               )''', re.VERBOSE)),

According to Python manual, \w matches [a-zA-Z0-9_], so a number literal of some small positive integer, e.g., 42, will always be recognized as a "name", not a number. This probably does not affect the result, but is a potential source of error when refactoring.

Hi, I'd like to work on this. I'll submit a PR shortly.

Navigation Menu

Repository navigation

Minor bug in JavaScript lexer; failing to recognize numbers #789

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	('name', name_re),
	('number', re.compile(r'''(
	(?:0\|[1-9]\d*)
	(\.\d+)?
	([eE][-+]?\d+)? \|
	(0x[a-fA-F0-9]+)
	)''', re.VERBOSE)),

Minor bug in JavaScript lexer; failing to recognize numbers #789

Description

Activity

nightcityblade commented on Aug 12, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions