Repository navigation
Clean up test coverage: omit generators, drop dead dtypes copy, test tutorial offline - #11703
Merged
Merged
Conversation
…tutorial offline - Omit the code generators in xarray/util from the coverage, they are run by hand and never imported by the tests - Remove xarray/namedarray/dtypes.py, which was copied from xarray/core/dtypes.py in pydata#8250 for a standalone namedarray but never used, and has diverged since - Test xarray.tutorial without network access by faking pooch.retrieve Co-authored-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
headtr1ck
added
topic-testing
plan to merge
On Windows an open file cannot be removed, so open_dataset and open_datatree with cache=False failed. The test now also catches an unclosed file on other platforms. Co-authored-by: Claude <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dcherian
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes some misleading entries in the Codecov report.
xarray/util/generate_*.pyfrom the coverage. They are run by hand and never imported by the tests (mypy already excludes them).xarray/namedarray/dtypes.py. It was copied fromxarray/core/dtypes.pyin copy thedtypesmodule to thenamedarraypackage. #8250 towards a standalone namedarray, but nothing ever imported it (namedarray usesxarray.core.dtypes), and the copy has fallen behind (no extension or string dtype support).xarray.tutorialwithout network access by fakingpooch.retrieve, raising its coverage from ~29% to 99%. The existing download tests stay behind@network.Checklist
whats-new.rstAI Disclosure
Tools: Claude Code
[This is Claude Code on behalf of Michael Niklas]
🤖 Generated with Claude Code