Repository navigation
feat(numpy): support negative indices in checked array accessors - #6201
Merged
Merged
Conversation
Use a single unsigned bounds compare, say in the error message that negative indices are not supported, document the behavior on the accessors, and cover offset_at/offset_at_t in test_bounds_check. Assisted-by: ClaudeCode:claude-opus-5-5
I accidentally merged pybind#6187 instead of this PR. I’ve now merged `master` into this branch, preserving exactly the same Git tree as the previously tested version of pybind#6201. Only the commit history has changed, so I’ll merge without running CI again.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #6187, retaining both of its commits and adding NumPy-style negative indexing for checked
array/array_taccessors and negative axes forshape()/strides().#6187 rejects all negative indices; this wraps valid negative indices (
-1selects the last element or axis) and raisesIndexErrorfor indices outside the valid range. Unchecked accessors keep their existing behavior. See the discussion and local cost comparison.Validation: local default and free-threaded CPython 3.14.4 test suites and
prek -a --quietpassed.Suggested changelog entry:
arrayandarray_taccessors.📚 Documentation preview 📚: https://pybind11--6201.org.readthedocs.build/