Repository navigation
fix(Avatar): prevent unexpected sizing collapse in Button leadingVisual and flex layouts (#7974) - #8645
Open
Rustaman1280 wants to merge 1 commit into
Open
fix(Avatar): prevent unexpected sizing collapse in Button leadingVisual and flex layouts (#7974)#8645Rustaman1280 wants to merge 1 commit into
Rustaman1280 wants to merge 1 commit into
Conversation
…ng collapse (primer#7974) - Add min-width and flex-shrink: 0 to :where(.Avatar) - Add min-width to responsive avatar query styles - Add regression test rendering Avatar in Button leadingVisual slot - Add changeset for patch release Signed-off-by: crustdev <dev@crusts.dev>
🦋 Changeset detectedLatest commit: a56c8ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7974
Summary
When an
Avatarcomponent is passed into theleadingVisualslot of aButton(or inside certain CSS grid / flex containers), global stylesheets specifyingimg { max-width: 100% }can cause the intrinsic width calculation ofmin-contentgrid areas to resolve unexpectedly to zero or collapse the avatar.As diagnosed in #7974, adding
min-widthalongsidewidth(andflex-shrink: 0) guarantees the Avatar always retains its intended visual dimensions across both standard and responsive size variants.Changes
min-width: var(--avatarSize-regular);andflex-shrink: 0;to:where(.Avatar).min-widthproperties to the--viewportRange-narrow,--viewportRange-regular, and--viewportRange-wideresponsive query blocks.Avatarrendered insideButtonleadingVisualslot maintains expected dimensions.Verification
npm run lint:css: Passed with zero warnings.npx vitest run packages/react/src/Avatar/Avatar.test.tsx: 6/6 tests passed.npx vitest run packages/react/src/Button/__tests__/Button.test.tsx: 60/60 tests passed.