Skip to content

perf(react-compiler): enable ActionMenu - #8563

Open
joshblack wants to merge 1 commit into
joshblack/react-compiler-button-basefrom
joshblack/react-compiler-action-menu
Open

joshblack wants to merge 1 commit into
joshblack/react-compiler-button-basefrom
joshblack/react-compiler-action-menu

Conversation

@joshblack

@joshblack joshblack commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Follow up to #8564.

This PR enables React Compiler for ActionMenu. We replace the captured renderAnchor reassignment with a local object accumulator, preserving the existing child traversal, tooltip handling, and merged anchor handlers.

Public APIs stay unchanged.

Changelog

New

Changed

  • Enable React Compiler for ActionMenu.

Removed

Rollout strategy

Selected minor for the compiler rollout, consistent with the earlier entries in this stack. No consumer migration is needed.

  • No changes needed in github/github-ui
  • Needs changes in github/github-ui
  • Ships with feature flag(s)
  • Not sure
  • None

@changeset-bot

changeset-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e6b3ab8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joshblack
joshblack added this pull request to stack #8559 October 16, 2026 16:47
@github-actions github-actions Bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions
github-actions Bot temporarily deployed to storybook-preview-8563 October 16, 2026 16:56 Inactive
@github-actions github-actions Bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Oct 16, 2026
@joshblack
joshblack force-pushed the joshblack/react-compiler-action-menu branch from c4cd26d to 08e2121 Compare October 19, 2026 21:15
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8563 October 19, 2026 21:30 Inactive
@joshblack
joshblack force-pushed the joshblack/react-compiler-action-menu branch from 08e2121 to 66cda36 Compare October 20, 2026 16:12
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8563 October 20, 2026 16:23 Inactive
@joshblack
joshblack force-pushed the joshblack/react-compiler-action-menu branch from 66cda36 to e6b3ab8 Compare October 20, 2026 16:45
@joshblack
joshblack marked this pull request as ready for review October 20, 2026 16:46
@joshblack
joshblack requested a review from a team as a code owner October 20, 2026 16:46
@joshblack
joshblack requested review from francinelucca and a balanced review from Copilot October 20, 2026 16:46
@joshblack joshblack removed the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Oct 20, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Static review identified no blocking issues in the behavior-preserving refactor; runtime and compiler checks were not executed.

No open issues 🎉

What changed in this PR

Continues the React Compiler rollout after #8564 by enabling it for ActionMenu, without changing public APIs.

Changes:

  • Replaces captured anchor reassignment with a local object accumulator.
  • Removes ActionMenu from compiler exclusions.
  • Adds a minor-release changeset.
File Description
packages/​react/​src/​ActionMenu/​ActionMenu.tsx Refactors anchor handling for compiler compatibility.
packages/​react/​script/​react-compiler.mjs Enables compilation of ActionMenu.
.changeset/​react-compiler-action-menu.md Records the rendering-performance improvement.

Review effort: Balanced

@primer-integration

Copy link
Copy Markdown

Integration test results from github/github-ui PR:

Passed  Changes   Passed
Passed  CI   Passed
Passed  VRT   Passed
Passed  Projects   Passed

All checks passed!

@github-actions github-actions Bot added the integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh label Oct 20, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e632d4e3-54d2-4423-9888-8e37b00494a3
@joshblack
joshblack force-pushed the joshblack/react-compiler-action-menu branch from e6b3ab8 to c872610 Compare October 20, 2026 19:07
@github-actions github-actions Bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Action required

👋 Hi, there are new commits since the last successful integration test. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Check the integration testing docs for step-by-step instructions. Or, apply the integration-tests: skipped manually label to skip these checks.

This branch was successfully deployed

2 active deployments
storybook-preview-8563 — c872610c Deployed Oct 20, 2026 by github-actions[bot]
github-pages — c872610c Deployed Oct 20, 2026 by joshblack via deploy-preview #33813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants