Repository navigation
Fix/avatar button leading visual sizing - #8550
Open
naveedsajjdawan wants to merge 6 commits into
Open
naveedsajjdawan wants to merge 6 commits into
naveedsajjdawan wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: 2930dbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 of 5 tasks
Add browser coverage that verifies consumer sizing overrides remain square, guarding against the regression exposed by primer#8550. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Avoid screenshot baselines for the development-only regression fixture so the test fails only when computed dimensions change. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
liuliu-dev
requested changes
Oct 16, 2026
liuliu-dev
left a comment
liuliu-dev
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this! Adding min-width introduces a sizing regression. Here’s a minimal reproduction:
<div style={{'--avatar-size': '16px'} as React.CSSProperties}>
<Avatar
src="https://github.com/github.png"
style={{
width: 'var(--avatar-size)',
height: 'var(--avatar-size)',
}}
/>
</div>The new min-width remains 20px while the overridden width and height are 16px. The image therefore renders at 20px × 16px and appears stretched.
Could we address the issue without changing the rendered dimensions in this case?
|
Integration test results from github/github-ui PR: |
github-actions
Bot
added
the
integration-tests: failing
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing