Skip to content

fix: OsOperations::get_user is not implemented (restore prev code) #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 1 commit into from
Sep 15, 2026
Merged

fix: OsOperations::get_user is not implemented (restore prev code) #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/os_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def reset_env(
RaiseError.MethodIsNotImplemented(__class__, "reset_env")

def get_user(self) -> typing.Optional[str]:
RaiseError.MethodIsNotImplemented(__class__, "get_user")
return self.username

def get_name(self) -> str:
RaiseError.MethodIsNotImplemented(__class__, "get_name")
Expand Down
11 changes: 11 additions & 0 deletions tests/test_os_ops_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,17 @@ def test_prop__username(self, os_ops_descr: OsOpsDescr):
assert v is None or type(v) is str
return

def test_prop__get_user(self, os_ops_descr: OsOpsDescr):
assert type(os_ops_descr) is OsOpsDescr
assert isinstance(os_ops_descr.os_ops, OsOperations)

os_ops = os_ops_descr.os_ops
assert isinstance(os_ops, OsOperations)

v = os_ops.get_user()
assert v is None or type(v) is str
return

def test_get_platform(self, os_ops_descr: OsOpsDescr):
assert type(os_ops_descr) is OsOpsDescr
assert isinstance(os_ops_descr.os_ops, OsOperations)
Expand Down