Repository navigation
chore: require PyJWT >= 2.15.0 on Python 3.9+; remove stale requirements files - #866
Merged
Merged
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Contributor
Author
|
CI failure is #864 |
Contributor
Seems like the strat could be to just merge this and then fix-forward anything that breaks - does that feel right to you? |
zackverham
approved these changes
Oct 14, 2026
…nts files PyJWT 2.15.0 fixes the open Dependabot advisories that have a fix. It needs Python >= 3.9, so 3.8 keeps the old floor. requirements.txt and docs/requirements.txt are out of date and unused in this repo: snyk.yml regenerates requirements.txt before scanning, and the docs build uses the `docs` dependency group. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
nealrichardson
force-pushed
the
remove-stale-requirements
branch
from
October 14, 2026 13:45
41a823f to
16e8e90
Compare
Contributor
Author
Yes, I think #649 is stale because we've done most of that already. |
nealrichardson
enabled auto-merge (squash)
October 14, 2026 13:47
amol-
approved these changes
Oct 14, 2026
nealrichardson
disabled auto-merge
October 14, 2026 14:10
nealrichardson
enabled auto-merge (squash)
October 14, 2026 14:10
nealrichardson
disabled auto-merge
October 14, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyJWT floor
Open Dependabot alerts include about 20 PyJWT advisories (one critical) against the locked 2.13.0. The fixes are in 2.14.0 and 2.15.0, and both need Python ≥ 3.9, so a plain floor would make the package uninstallable on 3.8. This uses version markers instead:
rsconnect only calls
jwt.encode(..., algorithm="HS256")(rsconnect/json_web_token.py). Most of the advisories are in decoding andPyJWKClientpaths that rsconnect doesn't use, so this is mostly to protect users' environments. One advisory (#143) has no fixed release yet.uv.lockwas regenerated with uv 0.13.0; the only change is pyjwt 2.13.0 → 2.15.1 for 3.9+.Remove
requirements.txtanddocs/requirements.txtBoth are out of date. The root file lists
six,black,flake8,setuptools_scmandsemver<3, none of which are dependencies anymore. Nothing in this repo reads either file:snyk.ymlregeneratesrequirements.txtwithuv pip compilebefore scanning, and the docs build usesuv run --group docs.Testing
tests/test_json_web_token.pypasses on 3.8 (old PyJWT) and 3.13 (PyJWT 2.15.1).uv lock --lockedis clean.🤖 Generated with Claude Code