Repository navigation
fix(N8AO): use the EffectComposer's camera and scene - #396
Merged
Merged
Conversation
kvvasuu
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<N8AO>readcameraandscenefromuseThree(), so it ignored thecameraandsceneprops of<EffectComposer>. Every other component (LensFlare,Outline,SelectiveBloom,GodRays,DepthOfField,useDepthPicking) reads them fromEffectComposerContext.N8AOPostPassuses its camera for all AO math (projection and view matrices, depth reconstruction) and renders its scene with it. When the composer renders a different camera than the canvas default, the depth buffer comes from one camera and the AO is reconstructed with another, so the occlusion is misplaced. Switching the composer's camera also left N8AO on the old one.Changes
src/passes/N8AO.tsx: takecameraandscenefromEffectComposerContext.invalidatestill comes fromuseThree.src/tests/N8AO.test.tsx: add a test that checks the pass gets the composer's camera and scene, and follows a camera change.Testing
pnpm vitest run src/tests/N8AO.test.tsx: the new test fails without the fix (1 failed, 3 passed) and passes with it (4 passed).pnpm test: 29 files, 221 tests passed.pnpm typecheck,pnpm eslint:ciand Prettier are clean.