Repository navigation
Prevent race condition by enabling page events before navigation - #482
Open
dennisjlee wants to merge 1 commit into
Open
dennisjlee wants to merge 1 commit into
dennisjlee wants to merge 1 commit into
Conversation
dennisjlee
force-pushed
the
fix/enablePageBeforeNavigate
branch
from
October 19, 2026 19:39
7c4ef58 to
9716368
Compare
Contributor
|
I'll review this and follow up. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #481
Note on why the fix works:
Page.enableenables page notifications, but doesn’t promise to replay a previousPage.loadEventFired. Chromium’s implementation enables the agent without replaying that event.