Repository navigation
fix: make Claude binary provider lanes work with Claude Code 2.1 - #95
Merged
Merged
Conversation
Remove --permission-mode plan from the claude argv in the candidate, chat, and live provider adapters. Claude Code 2.1 refuses to emit the requested deliverable in plan mode and returns prose instead, so every New task build failed with task_provider_output_invalid. Tools are already disabled with --tools "", so plan mode added no containment. State the base_hash contract explicitly in the candidate prompt (null for create, the input file's content_hash for replace). Without it the model sometimes returned a string for new files, failing task_provider_base_hash_invalid. Verified end to end on Windows with claude.exe 2.1.296 under a Claude Max login: goal -> candidate ready -> structural check exit 0 -> accept -> apply wrote the file to the project. Full pytest suite passes. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--permission-mode planfrom theclaudeargv in the candidate, chat, and live provider adapters. Claude Code 2.1 refuses to emit the requested deliverable in plan mode and returns prose, so every New task build failed withtask_provider_output_invalid. Tools are already disabled with--tools "", so plan mode added no containment.base_hashcontract explicitly in the candidate prompt:nullfor create, the input file'scontent_hashfor replace. Without it the model sometimes returned a string for new files and the build failed withtask_provider_base_hash_invalid.Verification
OwnedProcessagainstclaude.exe2.1.296 under a Claude Max login.hello.pyto the configured project, and the file runs.python -m pytestfull suite: exit 0.Not covered
🤖 Generated with Claude Code