Repository navigation
Pin the iteratee's entry types in the by-ref foreach intertwined expression - #6217
Merged
Merged
Conversation
…ession The SetExistingOffsetValueTypeExpr subject re-priced the raw iteratee through Scope::getType() on every ask of the intertwined node. The iteratee's phpdoc and native types at loop entry are already threaded into enterForeach(), and the sibling key expression already pins them the same way; the outer IntertwinedVariableByReferenceWithExpr keeps carrying the raw iteratee, so invalidation on reassignment is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from the resolve-type-rewrite branch. The
SetExistingOffsetValueTypeExprsubject inside the by-ref foreachIntertwinedVariableByReferenceWithExprre-priced the raw iteratee throughScope::getType()on every ask of the intertwined node. The iteratee's phpdoc and native types at loop entry are already threaded intoenterForeach()(#6162), and the sibling key expression already pins them the same way.The outer
IntertwinedVariableByReferenceWithExprkeeps carrying the raw iteratee, so invalidation on reassignment is unchanged. Both test suites pass with zero expectation churn.🤖 Generated with Claude Code
https://claude.ai/code/session_01DaBZjgksga4c5s6Q9FniY7