Skip to content

ext/intl: Remove redundant SKIPIF checks from intl tests - #24416

Merged
LamentXU123 merged 1 commit into
php:masterfrom
LamentXU123:skipif
Oct 19, 2026
Merged

LamentXU123 merged 1 commit into
php:masterfrom
LamentXU123:skipif

Conversation

@LamentXU123

@LamentXU123 LamentXU123 commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

These SKIPIFs are hidding issues. Spoofchecker INTL_IDNA_VARIANT_UTS46 Normalizer::FORM_KC_CF should be registed and exist in all of our supported version of ICU. If they are not then we are in trouble and the tests should reflect that.

The following code block shows that they are all registed without any conditions.

php-src/ext/intl/php_intl.c

Lines 222 to 223 in 73d069e

/* Register 'Spoofchecker' PHP class */
spoofchecker_register_Spoofchecker_class( );

REGISTER_LONG_CONSTANT("INTL_IDNA_VARIANT_UTS46", INTL_IDN_VARIANT_UTS46, CONST_PERSISTENT);

zval const_FORM_KC_CF_value;
ZVAL_LONG(&const_FORM_KC_CF_value, NORMALIZER_FORM_KC_CF);
zend_string *const_FORM_KC_CF_name = zend_string_init_interned("FORM_KC_CF", sizeof("FORM_KC_CF") - 1, true);
zend_declare_typed_class_constant(class_entry, const_FORM_KC_CF_name, &const_FORM_KC_CF_value, ZEND_ACC_PUBLIC, NULL, (zend_type) ZEND_TYPE_INIT_MASK(MAY_BE_LONG));
zend_string_release_ex(const_FORM_KC_CF_name, true);

@LamentXU123
LamentXU123 merged commit 8db89af into php:master Oct 19, 2026
11 of 18 checks passed
@LamentXU123
LamentXU123 deleted the skipif branch October 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants