Repository navigation
Conversation
BusyBox ps, as used on Alpine, does not support -p. Check whether the worker processes still exist with the POSIX kill -0 builtin instead. The poll loop already waits for the workers to disappear, so transient zombies are handled. Use command -v instead of which to detect pgrep, and skip when shell_exec() is unavailable.
Sjord
marked this pull request as ready for review
October 18, 2026 16:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BusyBox ps, as used on Alpine, does not support -p. Check whether the worker processes still exist with the POSIX kill -0 builtin instead. The poll loop already waits for the workers to disappear, so transient zombies are handled.
Use command -v instead of which to detect pgrep, and skip when shell_exec() is unavailable.